Closed jiahao1553 closed 2 years ago
@olsh Please have a look. Thanks.
Hi @jiahao1553,
Thank you for a great job! 🔝 Could you please take a look at the suggestions?
@olsh I updated the code based on your comments. Let me know if there is anything else you need me to update 😊
Hi @jiahao1553 Thank you for the update 👍🏻 Could you please take a look a the suggestions?
@olsh please take a look at my reply. Thanks
@jiahao1553 which one? I think I've replyed in all our threads.
@olsh this is the reply I meant. Hope it answer your question.
https://github.com/olsh/curl-to-csharp/pull/99#discussion_r985095581
@olsh this is the reply I meant. Hope it answer your question.
Ouch, my bad, I forgot to hit the request changes button.
@olsh changes are done. Please take a look. Thanks 😊
Replied and updated the code. Please take a look @olsh
@jiahao1553 let's drop .netstandard and try to keep the code as it is for now. https://github.com/olsh/curl-to-csharp/pull/99#discussion_r990691634 Also, could you please merge master branch to your branch to resolve conflicts?
@olsh I have completed the changes. Please take a look. Thanks.
Thank you for the contribution
You're welcome @olsh :)
@jiahao1553 I published the packages, thank you! 👍🏻 https://www.nuget.org/packages/Curl.CommandLine.Parser/ https://www.nuget.org/packages/Curl.HttpClient.Converter/
Sorry for the delay in making the code changes you mentioned in #63. Please review the request. Thank you.