olsh / curl-to-csharp

curl to C# converter
https://curl.olsh.me
MIT License
225 stars 42 forks source link

Publish as Curl.Parser.Net and Curl.Converter.Net as NuGet packages #99

Closed jiahao1553 closed 2 years ago

jiahao1553 commented 2 years ago

Sorry for the delay in making the code changes you mentioned in #63. Please review the request. Thank you.

jiahao1553 commented 2 years ago

@olsh Please have a look. Thanks.

olsh commented 2 years ago

Hi @jiahao1553,

Thank you for a great job! 🔝 Could you please take a look at the suggestions?

jiahao1553 commented 2 years ago

@olsh I updated the code based on your comments. Let me know if there is anything else you need me to update 😊

olsh commented 2 years ago

Hi @jiahao1553 Thank you for the update 👍🏻 Could you please take a look a the suggestions?

jiahao1553 commented 2 years ago

@olsh please take a look at my reply. Thanks

olsh commented 2 years ago

@jiahao1553 which one? I think I've replyed in all our threads.

jiahao1553 commented 2 years ago

@olsh this is the reply I meant. Hope it answer your question.

https://github.com/olsh/curl-to-csharp/pull/99#discussion_r985095581

olsh commented 2 years ago

@olsh this is the reply I meant. Hope it answer your question.

#99 (comment)

Ouch, my bad, I forgot to hit the request changes button.

jiahao1553 commented 2 years ago

@olsh changes are done. Please take a look. Thanks 😊

jiahao1553 commented 2 years ago

Replied and updated the code. Please take a look @olsh

olsh commented 2 years ago

@jiahao1553 let's drop .netstandard and try to keep the code as it is for now. https://github.com/olsh/curl-to-csharp/pull/99#discussion_r990691634 Also, could you please merge master branch to your branch to resolve conflicts?

jiahao1553 commented 2 years ago

@olsh I have completed the changes. Please take a look. Thanks.

olsh commented 2 years ago

Thank you for the contribution

jiahao1553 commented 2 years ago

You're welcome @olsh :)

olsh commented 2 years ago

@jiahao1553 I published the packages, thank you! 👍🏻 https://www.nuget.org/packages/Curl.CommandLine.Parser/ https://www.nuget.org/packages/Curl.HttpClient.Converter/