search

olsh / resharper-structured-logging

An extension for ReSharper and Rider that highlights structured logging templates and contains some useful analyzers
MIT License
142 stars 14 forks source link

Incompatibility with ReSharper 2023.3 #100

Closed AngieEl closed 11 months ago

AngieEl commented 1 year ago

Hi, it seems that Structure Logging has compatibility set to be compatible with ReSharper 2023.3 which causes quite unwelcome issues for the customers that have installed ReSharper 2023.3. Could you please change the compatibility so it won't be available for 2023.3 users?

olsh commented 1 year ago

Well, it looks like the issue with the Jetbrains validation process. image

The plugin uses compatible API and Jetbrains stated that if the validation has no issues, then the plugin will work with the new R# versions without any issues. Here is the blog post about the new API verifier. https://blog.jetbrains.com/dotnet/2023/05/26/the-api-verifier/

So, I'll update the target SDK when I have spare time. Meanwhile it would be nice to open an issue about the validation process.

AngieEl commented 1 year ago

Hi @olsh, thank you for the feedback. Indeed, there's an issue with our API verifier. We've filed it in our issue tracker - API Verifier doesnt' detect binary incompabitility when abstract property isn't implemented. You can follow it to get the latest updates.

jacobvalter commented 1 year ago

Voting for this one - seeing no activity on Jetbrains side :/

jacobvalter commented 12 months ago

Issue marked as fixed on JetBrains side…

olsh commented 12 months ago

I tried to migrate to the new SDK, but there are issues with tests https://ci.appveyor.com/project/olsh/resharper-structured-logging/builds/48373529

I'm going to fix them soon with JB developers' help.

olsh commented 12 months ago

It was fixed in 2023.3.0.315-eap04. The version was uploaded to the plugins repository and is waiting for approval from the JB team. Meanwhile, you can download binaries here https://ci.appveyor.com/project/olsh/resharper-structured-logging/builds/48384070/artifacts

adaskos commented 9 months ago

Hi. I tried using the above NuGet artifact with R# 2023.3.2 but it won't show in local extensions, as if it's not compatible. Should it work? Is there a reason why JB hasn't approved it yet?

olsh commented 9 months ago

The preview version was approved and it's compatible with Rider 2023.3.2 https://plugins.jetbrains.com/plugin/12832-structured-logging/edit/versions

As for R#. The 2023.2.0.305 should be compatible with R# 2023.3.2 https://plugins.jetbrains.com/plugin/12083-structured-logging/edit/versions

adaskos-signal commented 9 months ago

Thanks @olsh. I didn't realize that I have to enable Include prerelease packages to get the new version to appear. It all worked fine after that.