search

olsh / resharper-structured-logging

An extension for ReSharper and Rider that highlights structured logging templates and contains some useful analyzers
MIT License
141 stars 14 forks source link

Convert to Roslyn Analyzer #92

Closed ProximaB closed 1 year ago

ProximaB commented 1 year ago

Rider/Resharper supports Roslyn analyzers. Roslyn analyzers are now standard and should be used in replace of ReSharper analyzers.

ProximaB commented 1 year ago

https://github.com/Suchiman/SerilogAnalyzer/issues/62

olsh commented 1 year ago

I don't quite understand the motivation behind this "conversion". Could you please explain it in more detail?

ProximaB commented 1 year ago

The idea that riders should only have this feature fell when JetBrains realized that they cannot ignore Roslyn anymore. The analyzers should have been available for everyone, no matter what IDE they are using.

olsh commented 1 year ago

In this case, you probably should help https://github.com/Suchiman/SerilogAnalyzer project. I don't think that it is worth it to "convert" the extension to Roslyn. It's actually not converting, it's rewriting from scratch. The R# API and Roslyn API are completely different.

ProximaB commented 1 year ago

Ok, though I hope somehow this project be useful if it's ahead from SerilogAnalyzer in terms of completeness. https://github.com/serilog/serilog/issues/1938