search

olshevski / compose-navigation-reimagined

🌈 Type-safe navigation library for Jetpack Compose
https://olshevski.github.io/compose-navigation-reimagined/
MIT License
545 stars 18 forks source link

Possible migration to compose multiplatform? #29

Open rushiiMachine opened 1 year ago

rushiiMachine commented 1 year ago

Personally I love this library and use it in all of my projects however recently the question has come up of eventually support multiplatform (desktop, ios, etc.), however this does not. To my knowledge it wouldn't be difficult to migrate this library to KMP, (even more so given it doesn't use any platform apis..?)

I was curious if whether you would be interested in doing this or at least allowing a PR to support KMP.

olshevski commented 1 year ago

@rushiiMachine The core logic of the library is using just the Compose APIs. But what should be done about the Android architecture components (Lifecycle, ViewModels, SavedStateHandle) in KMP? They are platform-specific to Android. Should the library on iOS, Desktop, etc. just provide the navigation functionality without this features?

I didn't have a chance to work with KMP and Compose Multiplatform, so my current knowledge of the requirements for such a multiplatform library is lacking.

olshevski commented 5 months ago

@rushiiMachine Ok, since Compose for iOS finally reached beta, I feel like learning Compose Multiplatform is inevitable. I need to look into it.

jershell commented 2 months ago

@rushiiMachine The core logic of the library is using just the Compose APIs. But what should be done about the Android architecture components (Lifecycle, ViewModels, SavedStateHandle) in KMP? They are platform-specific to Android. Should the library on iOS, Desktop, etc. just provide the navigation functionality without this features?

I didn't have a chance to work with KMP and Compose Multiplatform, so my current knowledge of the requirements for such a multiplatform library is lacking.

Today CMP support viewModels, Lifecycle and SavedStateHandle. And targes as webJs and wasm reached alpha. Also webkit support wasmgc that means wpa on compose will replace clip\instant apps very well. Good point for support cmp