search

olszowka / Zambia

Web-based convention scheduling system
Other
14 stars 15 forks source link

Problem saving on Configuration Editor for certain tables #134

Open lostcarpark opened 3 years ago

lostcarpark commented 3 years ago

If I try to save a new row on the Rooms table, it fails because the DB table does not allow an empty string to be inserted into a Time field. I guess it would work if I specified times for all 6 open/close time fields, but there is no validation checking on the time fields. A possible fix would be to change SubmitEditConfigTable.php to save NULL rather than '' for empty cells.

If I try to save a new row to the RoomHasSet table, or select a different room or room set for an existing row, it fails to insert or update. It would appear that it attempts to insert/update the the room name/roomset name instead of the ID, and the insert fails because a numeric value is expected. The problem would appear to be that the JavaScript is putting the name rather than the ID into the grid.

This problem occurs on the Discon3 branch.

LVerhulst4321 commented 3 years ago

Whoops. My commit should not be part of this issue. I don't know how to unlink it from this issue.

olszowka commented 3 years ago

@LVerhulst4321 The #134 in the commit message caused the commit to be linked to this issue by github.