search

oltodosel / interSubs

Interactive subtitles for mpv. Instantly translate selected word/sentence.
MIT License
225 stars 20 forks source link

Add support for japanese #29

Closed 5p1r05 closed 4 years ago

5p1r05 commented 4 years ago

(at first, CONGRATULATIONS for this amazing project) just wanted to add that Japanese sentences don't have spaces between words, so the user cannot select individual elements. There is a python library that allows the tokenization of japanese sentences, you can add this feature (or I can try to)

oltodosel commented 4 years ago

Sorry, but I'm not going to do it. Open a pull request after you will have done it yourself.

Tinker somewhere in here: https://github.com/oltodosel/interSubs/blob/8c5406e7ec94b01509934e38d963bd6293ae1c76/interSubs.py#L1550-L1570

fxmarty commented 3 years ago

@5p1r05 https://github.com/fxmarty/rikai-mpv, have a look!