search

olubunmitosin / laravel_flutter_pusher

An easy pusher package for use with Laravel Echo. Supports Null satefy
MIT License
6 stars 16 forks source link

Cannot trigger channels with data #9

Open ebelevics opened 2 years ago

ebelevics commented 2 years ago

You can't trigger event with data from app, because on Android it's not implemented and on iOS it triggers only empty list. While I have copied this plugin locally and made changes with using link below as example, the package still doesn't offer it: https://github.com/chinloyal/pusher_client/blob/81fec442e5a6deaaf59a08c2ae89fd5597036b6b/android/src/main/kotlin/com/github/chinloyal/pusher_client/pusher/PusherService.kt

Yet, I'm thankful that this is one of few packages where this laravel websockets plugin in general works on both platforms

olubunmitosin commented 2 years ago

Thanks a lot for this bug report. I will be more than happy if you can also be a contributor to make this package more useful and complete for other developers.

Kindly let me know your thoughts on this. Thank you.

On Wed, Jun 15, 2022, 3:39 PM ebelevics @.***> wrote:

You can't trigger event with data from app, because on Android it's not implemented and on iOS it triggers only empty list. While I have copied this plugin locally and made changes with using link below as example, the package still doesn't offer it:

https://github.com/chinloyal/pusher_client/blob/81fec442e5a6deaaf59a08c2ae89fd5597036b6b/android/src/main/kotlin/com/github/chinloyal/pusher_client/pusher/PusherService.kt

Yet, I'm thankful that this is one of few packages where this laravel websockets plugin in general works on both platforms

— Reply to this email directly, view it on GitHub https://github.com/olubunmitosin/laravel_flutter_pusher/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDKYNEHXVEF3PP2Z2GBOXLVPHTILANCNFSM5Y3R4A5A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ebelevics commented 2 years ago

Alright I'll add pull request somewhat later as I've never done this before, but I would gladly offer a change.

olubunmitosin commented 2 years ago

Awesome, thanks!

On Thu, Jun 16, 2022, 2:33 PM ebelevics @.***> wrote:

Alright I'll add pull request somewhat later as I've never done this before, but I would gladly offer a change.

— Reply to this email directly, view it on GitHub https://github.com/olubunmitosin/laravel_flutter_pusher/issues/9#issuecomment-1157667553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDKYNDXFWABMINADJOIYHTVPMUJTANCNFSM5Y3R4A5A . You are receiving this because you commented.Message ID: @.***>

NViktors commented 2 years ago

@ebelevics Any updates here?

je2781 commented 1 year ago

@ebelevics and @olubunmitosin any new updates on triggering events with data?