Develop

[Subhrans]

Hi @olucurious , I am waiting for your approval 😃 . Please check, if all is okay, then we can merge.

Thanks

[Subhrans]

Hi @olucurious, We need to deploy these changes before 21st June 2024. Please merge accordingly. If you find any bug I will fix it immediately.

Thanks

[Subhrans]

@olucurious, Hi, Still i am waiting for your reply on this PR.

[saikreddy]

yes @olucurious, please review and merge the PR, as the deadline is 20th June for the legacy FCM APIs to get deprecated

[olucurious]

I'm doing some refactoring, but an update will be pushed today

[Subhrans]

@olucurious , Thanks for the reply. Ping me if you need anything. I am available.

[saikreddy]

Hi @olucurious, sorry to bother you, but could you please review and merge the PR at your earliest convenience? We need sufficient time to test it in our dev environments before moving it to production.

[almaz1213]

... as always on the last day ))) please, drop here some instruction to update via pip. thanks in advance

[olucurious]

Hey fellas, some necessary breaking changes are introduced in the new version(https://github.com/olucurious/PyFCM/tree/develop) due to changes and limitations in the v1 API.

Any thoughts before I push to pypi?

[Subhrans]

Hey fellas, some necessary breaking changes are introduced in the new version(https://github.com/olucurious/PyFCM/tree/develop) due to changes and limitations in the v1 API.

Any thoughts before I push to pypi?

No, everything is fine, Did you check in your machine? If everything is working same, then I am happy to see this to be merged 🙂

[olucurious]

Thank you so much @Subhrans for kicking off the migration with your PR contribution 👏🏾👏🏾

[jhonsoto-aflore]

@olucurious and @Subhrans TypeError: send_async_request() got an unexpected keyword argument 'payloads'

[wkpark]

See also https://github.com/olucurious/PyFCM/pull/308

[olucurious]

Fixed in 2.0.2

[almaz1213]

we have error !

steps:

1. updated pyfcm to 2.0.2
2. generated new fcmServiceAccKey.json in the Firebase console
3. our android app got new fcm token for a user

test code on the server side:

from pyfcm import FCMNotification

fcm = FCMNotification(service_account_file=<absolute path to>fcmServiceAccKey.json', project_id='iolmsg-filestore')

res = fcm.notify(<user token from step 3>, 'title', 'text')

print(res)

result:

use to use method .notify_single_device but now FCMNotification has no this method

[olucurious]

Can you manually test from the Firebase console?

[Subhrans]

Hi @olucurious, Why I can't see myself on the contributor list?