olucurious / PyFCM

Python client for FCM - Firebase Cloud Messaging (Android, iOS and Web)
http://olucurious.github.io/PyFCM/
MIT License
802 stars 204 forks source link

Documentation indicates just the service file is needed: #330

Closed LawrenceK closed 2 months ago

LawrenceK commented 2 months ago

Documentation for indicates just the service file is needed: FCMNotification(service_account_file=config.firebase["service_file"])

But run time reports requires project_id

pushClient = FCMNotification(service_account_file=config.firebase["service_file"])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: BaseAPI.init() missing 1 required positional argument: 'project_id'

olucurious commented 2 months ago

Thanks, fixed in this commit