search

olvid-io / olvid-android

Olvid for Android
GNU Affero General Public License v3.0
149 stars 14 forks source link

Prefers `_` over `|` for backup checkout on Windows #12

Closed HorlogeSkynet closed 1 year ago

HorlogeSkynet commented 1 year ago

Windows do not allow | in filenames, thus Olvid backups cannot be checked out on these platforms. This patch replaces this character by _, at the cost of being breaking for already existing backups.

Feel free to edit this PR as needed (maybe in a BC way ?).

Thanks, bye 👋

finiasz commented 1 year ago

Thanks a lot for your pull request. Indeed, when backups were only on Google Drive, this was not a problem. But now that we added webDAV support this is not very convenient. I will apply this change in our master repo and, when downloading a file, look for either | or _ in the filename. This will be fixed in the next release of Olvid!

HorlogeSkynet commented 1 year ago

From what I can see, a patch has been included in v0.13.0, but due to concerns already addressed in #9, it is not present here. Closing this PR due to fix, thanks again :bow:

finiasz commented 1 year ago

Indeed, this is resolved in the latest version: new backups use _ instead of |, but parsing backups on Google Drive/WabDAV supports both characters for backward compatibility.

Please feel free to reopen this issue if you run into any issue!