Attach build to GitHub releases

kumy commented 2 years ago

As said in https://github.com/olvid-io/olvid-android/issues/2#issuecomment-1004001931, it would be awesome to have already built packages signed by your own key attached to the GitHub releases. (it would also be nice to have the download apk link on your website)

This would help:

from having to build it manually
for having it included in alternatives repo such as F-droid IzzySoft
would permit to enable push notification(?)

Thanks a lot!

Edit: you can find my own automated builds at https://github.com/kumy/olvid-android/releases

kumy commented 1 year ago

New builds v0.13.3_195 https://github.com/kumy/olvid-android/releases/tag/v0.13.3_195-kumy1

Morse6690 commented 1 year ago

I just saw your response to the fdroid build request. Thanks for the update. Seeing that that won't happen at least in the short term, is adding an apk file to the releases section for each new release a possibility?

finiasz commented 1 year ago

Hello @Morse6690, we know several users would be interested in an official "non store" APK but we do not want to incentivize them to install APKs signed by a random key. Also, it would be easy for anyone impersonating the github website to distribute a malicious APK.

At least, F-Droid and Google Play can check the APK is properly signed.

Morse6690 commented 1 year ago

I can understand your concerns with this. Having said that there is a use case for this, hence apps like signal make sure they provide an apk that can be downloaded from outside the play store. People who can't access the play store can either use a dodgy third party website like apkpure or similar or they just don't install it. I would think these third party app sites have far greater risk to an end user than an app placed by the developer on github, or hosted on your website in a non obvious location, similar to what signal has done. Of course these users cannot use the payment features of the play store to pay for the extras features. However I believe that the users who may be interested enough to download via this method are savvy enough understand the dangers. The average person will only ever use the play store.

kumy commented 11 months ago

Build ready v1.0_216-kumy1

Morse6690 commented 10 months ago

Is it possible to do something similar to signal? They provide an apk that can be downloaded directly from their own website. Users are prompted when a new update is available which can be installed by hitting "ok" on the "new update available" notification.

finiasz commented 10 months ago

Just a quick note here: we are now providing an APK for download directly from our website. This APK is a universal APK signed with the same keys as the version available on Google Play. This means push notifications can work for users with Google Services installed. We do not provide an APK for the "no google" flavor of the app.

https://olvid.io/download/

kumy commented 10 months ago

That's a great step forward, thanks. What are the reason behind the "We do not provide an APK for the "no google" flavor of the app."?

Morse6690 commented 10 months ago

Making sure the "use foreground service" option is turned on should mean that notifications will be received whether the device has Google play services installed or not? Is that right?

finiasz commented 10 months ago

Hi @Morse6690 , the "use foreground service" is not exactly for this. We have a "maintain a permanent websocket connection" option that can replace Google push notifications. The "use foreground service" is just there to prevent the app from being killed in the background by the system, but it's not that useful. The websocket connection will also use a foreground service to keep the app alive.

Keep in mind that the permanent websocket may drain the battery (a few percents in one day), so if you have too many apps doing the same as us, this might become an issue :)

Morse6690 commented 10 months ago

That's right... Forgot that other setting. I have used those two settings on my Graphenos device for 18 months. The battery drain was pretty minimal, and never had a problem receiving messages.

kumy commented 10 months ago

For those like me using the "no google" version, I'll continue to build the releases on my side. Here is v1.3_220-kumy1

kumy commented 1 week ago

I had to raise Graddle memory to have it build.

v3.2 is out 🙂

olvid-io / olvid-android

Attach build to GitHub releases #3