Closed negezor closed 1 year ago
@augustocdias @bassco could you please review and merge it?
I also upgraded num-derive to 0.4 to go to syn 2. Now the minimum MSVR is 1.56.
looks good to me but I'm not part of the organisation anymore. I can't approve/merge PRs.
I don't know if you want to tackle this, but a mistake I did was pushing the generated bidings from bindgen to github instead of always generating on build time. This will cause issues on different platforms as types has different types in each. If you're running on docker or linux (and probably mac as well) this should be fine, but on windows this will certainly fail.
@negezor would you mind creating a new repo for libvips and publishing it to crates.io (e.g. as vips)?
@augustocdias Do you still have contact to someone from the olxgroup-oss organization? It would be nice if this repository could still be maintained (by the community). Perhaps someone could be given the necessary access rights to this repository.
Otherwise I think a fork (and republishing) is necessary. It looks like vips name is already taken so one would have to find a new one
@bassco Look like that's it. Perhaps I'll come back later, as libvips version 8.15.0 is just around the corner 😄
UPD: I'll take this opportunity to update some more 😅
@negezor - I'll publish the crate in the next few hours once I get onto the work machine
cc @BogdanVidrean
The libvips library has moved to the new meson + ninja builder. I couldn't wait for crate to update myself, so I thought I'd suggest a PR. Let me know if there are any issues with this PR here.