search

olympus-robotics / mcap_builder

Add support to build and install MCAP with CMake
MIT License
9 stars 5 forks source link

Reference to zstd library #7

Open cvilas opened 3 hours ago

cvilas commented 3 hours ago

Hey @filippobrizzi

Thanks for this repo. Came handy trying to integrate mcap on a personal test project. Really strange the upstream project has flaky CMake support. Your MR would have solved it!

Anyway, on my machine (Kubuntu 24.04), the following had to be changed from zstd::libzstd to zstd::zstd. Just a heads up. Not sure if this was tested before https://github.com/olympus-robotics/mcap_builder/blob/main/src/CMakeLists.txt#L22

filippobrizzi commented 2 hours ago

Hey @cvilas, I just checked with the latest zstd version and it creates zstd::libzstd target. How do you compile it?

cvilas commented 48 minutes ago

On Kubuntu 24.04

cd mcap_builder/build
cmake ..

gives me:

-- The CXX compiler identification is GNU 14.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found zstd from /usr/lib/x86_64-linux-gnu/cmake/zstd
-- Configuring done (1.6s)
CMake Error at src/CMakeLists.txt:28 (target_link_libraries):
  Target "mcap" links to:

    zstd::libzstd

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

But I see now that zstd::zstd doesn't work either (I am confused. Sorry. Need to check if the behaviour is different on Fedora vs Ubuntu)