omab / django-social-auth

Django social authentication made simple
https://groups.google.com/group/django-social-auth
BSD 3-Clause "New" or "Revised" License
2.65k stars 757 forks source link

Mobile/Web Facebook Login Page #447

Closed liodakis closed 12 years ago

liodakis commented 12 years ago

Thanks for all the work you have done on django-social-auth. I have one question. I am running django-social-auth on a server that is accessed both via the web and mobile (phone-gap type app). Now if I use FACEBOOK_AUTH_EXTRA_ARGUMENTS = {'display': 'touch'} I get the mobile display on both web and mobile, but if I don't use the extra param I get the regular login on both. Is there a way to have it display normally on web and with the mobile login on mobile?

omab commented 12 years ago

@liodakis, sadly not at the moment, I wan't to settings more flexible but didn't found a proper solution so far. Meanwhile you can define a custom backend derived from the facebook one, that will check settings using other name, something like this::

from social_auth.bcakends.facebook import FacebookBackend, FacebookAuth

class MobileFacebookBackend(FacebookBackend):
    name = 'facebook-mobile'

class MobileFacebookAuth(FacebookAuht):
    AUTH_BACKEND = MobileFacebookBackend

BACKENDS = {
    'facebook-mobile': MobileFacebookAuth
}

Then add it to AUTHENTICATION_BACKENDS::

AUTHENTICATION_BACKENDS = (
    ...
    'yourapp.mobile_facebook.MobileFacebookBackend',
    ...
)

And add the needed setting for mobile layout::

FACEBOOK_MOBILE_AUTH_EXTRA_ARGUMENTS = {'display': 'touch'}

Edit: code markup

uruz commented 12 years ago

@omab Don't you think that this is a design flaw? Maybe there should be a model Application, which would store things like path to auth backend, public and secret keys, permissions, etc?

omab commented 12 years ago

@uruz, it is a design flaw, no doubt, but I don't think it should be solved with a model, a better structure of settings should be enough.

faxioman commented 12 years ago

This is my backend for addressing this problem:

from social_auth.backends.facebook import FacebookBackend, FacebookAuth

# Facebook configuration
FACEBOOK_ME = 'https://graph.facebook.com/me?'
ACCESS_TOKEN = 'https://graph.facebook.com/oauth/access_token?'

class FacebookMobileBackend(FacebookBackend):
    name = 'facebookmobile'

class FacebookMobileAuth(FacebookAuth):
    AUTH_BACKEND = FacebookMobileBackend

    def auth_extra_arguments(self):
        auth_settings = (super(FacebookMobileAuth, self).auth_extra_arguments()).copy()

        #when display = touch is requested, set to touch only if browsing with a mobile device
        if (auth_settings.get('display') == 'touch' and (not self.request.is_mobile)):
            del auth_settings['display']

        return auth_settings

# Backend definition
BACKENDS = {
    'facebookmobile': FacebookMobileAuth,
}

And this is the middleware for adding is_mobile to request:

# Adapted by Fabio Masini from http://detectmobilebrowsers.com/
# Ported by Matt Sullivan http://sullerton.com/2011/03/django-mobile-browser-detection-middleware/
import re

reg_b = re.compile(r"android.+mobile|avantgo|bada\\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\\/|plucker|pocket|psp|symbian|treo|up\\.(browser|link)|vodafone|wap|windows (ce|phone)|xda|xiino", re.I|re.M)
reg_v = re.compile(r"1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s\\-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|\\-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw\\-(n|u)|c55\\/|capi|ccwa|cdm\\-|cell|chtm|cldc|cmd\\-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc\\-s|devi|dica|dmob|do(c|p)o|ds(12|\\-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(\\-|_)|g1 u|g560|gene|gf\\-5|g\\-mo|go(\\.w|od)|gr(ad|un)|haie|hcit|hd\\-(m|p|t)|hei\\-|hi(pt|ta)|hp( i|ip)|hs\\-c|ht(c(\\-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i\\-(20|go|ma)|i230|iac( |\\-|\\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\\/)|klon|kpt |kwc\\-|kyo(c|k)|le(no|xi)|lg( g|\\/(k|l|u)|50|54|e\\-|e\\/|\\-[a-w])|libw|lynx|m1\\-w|m3ga|m50\\/|ma(te|ui|xo)|mc(01|21|ca)|m\\-cr|me(di|rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(\\-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)\\-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|\\-([1-8]|c))|phil|pire|pl(ay|uc)|pn\\-2|po(ck|rt|se)|prox|psio|pt\\-g|qa\\-a|qc(07|12|21|32|60|\\-[2-7]|i\\-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h\\-|oo|p\\-)|sdk\\/|se(c(\\-|0|1)|47|mc|nd|ri)|sgh\\-|shar|sie(\\-|m)|sk\\-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h\\-|v\\-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl\\-|tdg\\-|tel(i|m)|tim\\-|t\\-mo|to(pl|sh)|ts(70|m\\-|m3|m5)|tx\\-9|up(\\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|\\-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(\\-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|xda(\\-|2|g)|yas\\-|your|zeto|zte\\-", re.I|re.M)

class DetectMobileBrowser():
    def process_request(self, request):
        request.is_mobile = False
        if request.META.has_key('HTTP_USER_AGENT'):
            user_agent = request.META['HTTP_USER_AGENT']
            b = reg_b.search(user_agent)
            v = reg_v.search(user_agent[0:4])
            if b or v:
                request.is_mobile = True
omab commented 12 years ago

@faxioman, excelent, looks really good.

selwin commented 12 years ago

What about making FACEBOOK_AUTH_EXTRA_ARGUMENTS support callables that accept a single request argument and returns a dictionary? This way the extra arguments can be calculated during run time, depending on the request. Example:

def get_fb_params(request):
    # if request.is_mobile:
    ...

FACEBOOK_AUTH_EXTRA_ARGUMENTS = get_fb_params
selwin commented 12 years ago

Or better, also support specifying dotted path to callable: i.e:

FACEBOOK_AUTH_EXTRA_ARGUMENTS = 'path.to.callable'
liodakis commented 12 years ago

@faxioman, I agree with @omab, great solution

omab commented 12 years ago

Pull-request #453 introduced a solution to this issue too.