search

omab / django-social-auth

Django social authentication made simple
https://groups.google.com/group/django-social-auth
BSD 3-Clause "New" or "Revised" License
2.65k stars 756 forks source link

Fetch email when sign up with github #755

Closed shmygol closed 11 years ago

shmygol commented 11 years ago

Email is mentioned in the code (file backends/contrib/github.py) but doesn't really work

     details = {'username': response.get('login'),
                'email': response.get('email') or ''}
shmygol commented 11 years ago

Hi Matías. Can you tell how soon will it be in the stable version available by pip?

omab commented 11 years ago

@trilliput, I've released v0.7.26 to pypi. I guess you already know this, but to make your /emails endpoint work you need the proper scope (user or user:email) this grants you access to the private email addresses of the user, otherwise the app tries to get the public email address (the .get('email') or '' in the code).

shmygol commented 11 years ago

@omab Sure. Thanks!