omab / python-social-auth

Social auth made simple
http://psa.matiasaguirre.net
BSD 3-Clause "New" or "Revised" License
2.83k stars 1.09k forks source link

user_details Boolean fields #1017

Closed lklabs closed 7 years ago

lklabs commented 8 years ago

Type: Bug

Version: 0.2.21 Django: 1.9.2

File: social/pipeline/user.py Function: user_details

Description: Sometimes user model can store boolean flags obtained from checkbox. In this case details dict will contain boolean variable (which could be equal to False) In this case the code if value and hasattr(user, name): will never let the field name to update, because value == False

omab commented 7 years ago

I've added a fix for this on social-core. Only None values will be ignored.