Closed jschneier closed 8 years ago
@jschneier @omab is there a reason this PR cannot be merged?
It is very, very dear to me. :)
@macolo, the reason is that I'm in the middle of migrating the project to http://github.com/python-social-auth, I need to port the PRs there first.
@omab Can we at least merge this and then people can install from git? I think this is one of the last blockers for a lot of people to move to the new MIDDLEWARE
setting in Django. I see the ongoing migration to the split repos but realistically for now it doesn't look like people are using that.
@jschneier, sure, we can do it
@jschneier thanks for the fix :)
@omab would you mind to issue a new release including this? Thanks!
@omab sorry to insist, but is there anything blocking a Django 1.10 compatible package?
@tdruez, I'm porting the app to https://github.com/python-social-auth, I suggest using the git reference in the requirements.txt to get this fix since I don't plan any release on python-social-auth
until I fully port it to depend on the new packages.
Alright, good luck with the migration!
If you don't want to run the Git version, here's a workaround until this is released.
from django.utils.deprecation import MiddlewareMixin
import social.apps.django_app.middleware
class SocialAuthExceptionMiddleware(
social.apps.django_app.middleware.SocialAuthExceptionMiddleware,
MiddlewareMixin):
"""Work around Django 1.10 middleware incompatibility."""
pass
Closes #953