omab / python-social-auth

Social auth made simple
http://psa.matiasaguirre.net
BSD 3-Clause "New" or "Revised" License
2.83k stars 1.09k forks source link

Subclass MiddlewareMixin for Django 1.10 compat #1031

Closed jschneier closed 8 years ago

jschneier commented 8 years ago

Closes #953

macolo commented 8 years ago

@jschneier @omab is there a reason this PR cannot be merged?

It is very, very dear to me. :)

omab commented 8 years ago

@macolo, the reason is that I'm in the middle of migrating the project to http://github.com/python-social-auth, I need to port the PRs there first.

jschneier commented 8 years ago

@omab Can we at least merge this and then people can install from git? I think this is one of the last blockers for a lot of people to move to the new MIDDLEWARE setting in Django. I see the ongoing migration to the split repos but realistically for now it doesn't look like people are using that.

omab commented 8 years ago

@jschneier, sure, we can do it

tdruez commented 8 years ago

@jschneier thanks for the fix :)

@omab would you mind to issue a new release including this? Thanks!

tdruez commented 8 years ago

@omab sorry to insist, but is there anything blocking a Django 1.10 compatible package?

omab commented 8 years ago

@tdruez, I'm porting the app to https://github.com/python-social-auth, I suggest using the git reference in the requirements.txt to get this fix since I don't plan any release on python-social-auth until I fully port it to depend on the new packages.

tdruez commented 8 years ago

Alright, good luck with the migration!

danni commented 7 years ago

If you don't want to run the Git version, here's a workaround until this is released.

from django.utils.deprecation import MiddlewareMixin

import social.apps.django_app.middleware

class SocialAuthExceptionMiddleware(
        social.apps.django_app.middleware.SocialAuthExceptionMiddleware,
        MiddlewareMixin):
    """Work around Django 1.10 middleware incompatibility."""

    pass