django 1.8+ compat to ensure to_python is always called when accessing result from db..

omab / python-social-auth

Social auth made simple

http://psa.matiasaguirre.net

BSD 3-Clause "New" or "Revised" License

2.83k stars 1.09k forks source link

django 1.8+ compat to ensure to_python is always called when accessing result from db.. #897

Closed sbussetti closed 8 years ago

sbussetti commented 8 years ago

Without this extra_data field can be returned as its raw serialized string...

clintonb commented 8 years ago

This issue was introduced by #813. Django docs for reference: https://docs.djangoproject.com/en/1.9/howto/custom-model-fields/#converting-values-to-python-objects.

sbussetti commented 8 years ago

@clintonb yeah, the author of that patch removed SubFieldBase without reading the rest of the deprecation instructions from the Django docs which instruct you to provide from_db_value going forward. Not that it matters to me, but #813 would also break backwards compat...