search

omab / python-social-auth

Social auth made simple
http://psa.matiasaguirre.net
BSD 3-Clause "New" or "Revised" License
2.83k stars 1.09k forks source link

Pulling JSONField from a third-party package #910

Closed clintonb closed 7 years ago

clintonb commented 8 years ago

There isn't much value to having yet another implementation of JSONField in python-social-auth when plenty of others exist. This commit replaces the JSONField implementation with that from the package jsonfield. jsonfield is an extra requirement as specifed in setup.py.

NOTE: This implementation of JSONField does not support Django 1.7 or below.

clintonb commented 8 years ago

Related: #908 and #909

clintonb commented 8 years ago

@webjunkie why the 👎 ?

webjunkie commented 8 years ago

@clintonb Sorry I did not clarify this. I'm just -1 on putting another dependency in this project. It might introduce other problems and looking at it, it wasn't updated all year and has "Django 1.8 support" as a feature. Just my two cents.

omab commented 8 years ago

Worth pointing that django-jsonfield is looking for a new maintainer for a while https://github.com/bradjasper/django-jsonfield/issues/146.

omab commented 7 years ago

I'm closing this since pulling a third-party that didn't got a maintainer for a while will make things complicated.

Thanks!