Closed JacobCallahan closed 2 years ago
Merging #123 (15bcafb) into master (ba67cd7) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 517 505 -12
=========================================
- Hits 517 505 -12
Impacted Files | Coverage Δ | |
---|---|---|
fauxfactory/factories/choices.py | 100.00% <100.00%> (ø) |
|
fauxfactory/factories/dates.py | 100.00% <100.00%> (ø) |
|
fauxfactory/factories/internet.py | 100.00% <100.00%> (ø) |
|
fauxfactory/factories/strings.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Py 3.6 check failure looks to be unrelated to my changes and lies in the check tooling itself. Perhaps it's time to drop explicit 3.6 support and add 3.10?
I changed the random selection of some methods from comprehensions to uses of random.choices. Most improved by around 15%. However, gen_cjk saw a 5.5x speedup!
I then took it a bit further by moving random.seed out of each method call and into the module scope. This greatly improved the runtime of each changed method. Additionally, it should still alleviate the original concern solved with #81
Here are the observed performance changes