updated to work with fontawesome 6

omacranger / fontawesome-subset

Creates subsets of FontAwesome fonts for optimized use on the web.

GNU General Public License v3.0

66 stars 15 forks source link

updated to work with fontawesome 6 #19

Closed christopherpickering closed 2 years ago

christopherpickering commented 2 years ago

@omacranger Thanks for the tool!

This pr should address #16, it works for font awesome 6.

A few things to note:

There is no longer an svg font (I think acceptable as in the readme it is pointed out that the purpose of this is to avoid sag's)
There is an alert for missing icons (going from v5 to v6 had a lot to icon name changes):

Special thanks to saurori who provided 99% of the code in this pr.

christopherpickering commented 2 years ago

As a side note, I wish there were a way to verify the version of fontawesome in here:

If the fontawesome v < 6 and subset >=6, then
    reccommend  an older version of fontawesome-subset, or a new version of font awesome > then error
If the fontawesome  v >= 6 and subset < 6
    then reccommend  a newer version of fontawesome-subset, or n older version of font awesome > then error

christopherpickering commented 2 years ago

Closing, taken care of in pr #20.