Fix for issue #40 For short refreshes, spinner animation never really stops, completely freezes fragment in which it is used.

omadahealth / SwipyRefreshLayout

A SwipeRefreshLayout extension that allows to swipe in both direction

MIT License

963 stars 218 forks source link

Fix for issue #40 For short refreshes, spinner animation never really stops, completely freezes fragment in which it is used. #45

Closed intrepidclass closed 8 years ago

intrepidclass commented 8 years ago

See this video https://www.dropbox.com/s/k1m53u8zyjb2s3w/SwipyRefreshLayout_issue_40.mp4?dl=0 of me reproducing the issue where the spinning animation doesn't stop, which you can see the second time I pull down. After the activity restart is when I've applied this fix, and you can see the circle doesn't keep spinning anymore like before.

Also a small Javadoc fix.

intrepidclass commented 8 years ago

Note that for that video I had set the timeout to 200 ms instead of 2000, at line 98 of MainActivity.java

oliveeyay commented 8 years ago

Cool Thanks. I'm gonna release a 1.2.3 soon on maven.

Cheers

intrepidclass commented 8 years ago

Great!

oliveeyay commented 8 years ago

1.2.3 is up on maven. I added some tests also.

intrepidclass commented 8 years ago

Excellent.