search

omadahealth / SwipyRefreshLayout

A SwipeRefreshLayout extension that allows to swipe in both direction
MIT License
963 stars 218 forks source link

setProgressViewOffset method is not exposed #52

Open dionisi opened 8 years ago

dionisi commented 8 years ago

I need to offset the refresh circle, because my app has a header and the refresh circle was shown behind the header. I look at the code and found that there convenient methods for this "setProgressViewOffset". But this method was comment out. I uncommented it and it works fine, but I wonder why it isn't exposed is there any known issues around them

Thanks

oliveeyay commented 8 years ago

Good question why it's commented...haha You can do me a Pull Request with the code uncommented, and I'll publish a new version on maven if you want?

Cheers,

Olivier

artshell commented 8 years ago

This good idea. My app has a similar needs. The refresh circle was shown above the FragmentTabHost with out that behind. But must support "both direction", If can dynamically modify progress view offset by direction that perfect.

oliveeyay commented 8 years ago

If you want to do it, you can do a pull request to this library?

Cheers