Feat/prisma v5

[multipliedtwice]

Enables support of Prisma V5, and suppresses typescript errors in zod types for edge cases with complex models.

[syabro]

Are you sure you want to add .yarn/cache and lib/src?

[syabro]

lib/src?

[syabro]

fix: bring back /lib Why? AFAIS It's a build artifacts, why they needed in the repo?

[multipliedtwice]

Because the repo is used as npm dependency already.

On Fri, May 31, 2024, 12:17 Maxim Syabro @.***> wrote:

fix: bring back /lib Why? AFAIS It's a build artifacts, why they needed in the repo?

— Reply to this email directly, view it on GitHub https://github.com/omar-dulaimi/prisma-zod-generator/pull/93#issuecomment-2141247943, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBCF36YNFPWXGRXSYCDA63ZFABV5AVCNFSM6AAAAABHXO3WCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGI2DOOJUGM . You are receiving this because you authored the thread.Message ID: @.***>

[syabro]

@multipliedtwice nope

1. lib is already ignored. https://github.com/omar-dulaimi/prisma-zod-generator/blob/master/.gitignore
2. npm package is orthogonal to the git repo. npm builds a package from the files where npm publish is being run, not from the repo itself

[multipliedtwice]

I mean my own repo that is a source of changes is already used in build pipeline as npm dependency. Removing /lib breaks the pipeline

On Fri, May 31, 2024, 14:21 Maxim Syabro @.***> wrote:

@multipliedtwice https://github.com/multipliedtwice nope

1. lib is already ignored. https://github.com/omar-dulaimi/prisma-zod-generator/blob/master/.gitignore
2. npm package is orthogonal to the git repo. npm builds a package from the files where npm publish is being run, not from the repo itself

— Reply to this email directly, view it on GitHub https://github.com/omar-dulaimi/prisma-zod-generator/pull/93#issuecomment-2141377420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBCF36F46BUCBOOFU625VTZFAQGZAVCNFSM6AAAAABHXO3WCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGM3TONBSGA . You are receiving this because you were mentioned.Message ID: @.***>

[syabro]

I mean my own repo that is a source of changes is already used in build pipeline as npm dependency. Removing /lib breaks the pipeline

Then I bet it wouldn't be merged 🙂

[multipliedtwice]

The author has no time to do it anyway. And I personally don't care if it's merged or not.

On Fri, May 31, 2024, 14:52 Maxim Syabro @.***> wrote:

I mean my own repo that is a source of changes is already used in build pipeline as npm dependency. Removing /lib breaks the pipeline

Then I bet it wouldn't be merged 🙂

— Reply to this email directly, view it on GitHub https://github.com/omar-dulaimi/prisma-zod-generator/pull/93#issuecomment-2141419453, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBCF334EJNHCEMGDVUUYSLZFAT4DAVCNFSM6AAAAABHXO3WCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGQYTSNBVGM . You are receiving this because you were mentioned.Message ID: @.***>

[syabro]

@multipliedtwice why did you create a PR to the author's repo then? 🙂

[multipliedtwice]

just in case someone doesn't want to do the same job all over again

On Fri, May 31, 2024 at 2:59 PM Maxim Syabro @.***> wrote:

@multipliedtwice https://github.com/multipliedtwice why did you create a PR to the author's repo then? 🙂

— Reply to this email directly, view it on GitHub https://github.com/omar-dulaimi/prisma-zod-generator/pull/93#issuecomment-2141428960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBCF34MJEDORL6IMJ3QTBTZFAUX3AVCNFSM6AAAAABHXO3WCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGQZDQOJWGA . You are receiving this because you were mentioned.Message ID: @.***>

[syabro]

just in case someone doesn't want to do the same job all over again

totally makes sense, thank you