search

omar-dulaimi / trpc-shield

🛡 A tRPC tool to ease the creation of permission layer.
MIT License
402 stars 10 forks source link

fix: always use fallbackRule if rule not found #22

Closed svengau closed 6 months ago

svengau commented 1 year ago

This PR is to fix a sneaky bug: when using with namespaced routers, the fallbackRule is never called.

Thanks!

zoey-kaiser commented 8 months ago

@omar-dulaimi +1

Please merge this. We need it pretty desperately 🙏

scoussens-nthplusio commented 8 months ago

Yeah, without this it's not really useable with namespaces.

svengau commented 8 months ago

@omar-dulaimi ?

omar-dulaimi commented 6 months ago

Hey everyone, apologies for the delay

omar-dulaimi commented 6 months ago

I'm going to assume it's working fine for you guys without other side effects, and release it now

omar-dulaimi commented 6 months ago

Released in: https://github.com/omar-dulaimi/trpc-shield/releases/tag/0.4.4

Let me know how it goes.

Also, if you can, please consider supporting me to allocate time for this project and others. I have stepped away from Open Source for a few months now, but would love to comeback. The lacking nature of open source support doesn't help me and others to stay motivated for continued work. Hope this changes soon.