search

omar-haris / nginx-rtmp-monitoring

real-time monitoring statistics dashboard for nginx rtmp module
MIT License
293 stars 92 forks source link

Add docker support #3

Closed espizo closed 7 years ago

omar-haris commented 7 years ago

@espizo thanks for your pull request are you test it at docker and worked ?

espizo commented 7 years ago

Hi!

Seems to work fine for me with a remote nginx-rtmp server!

If you have docker yourself, then it should be fairly easy to verify with the docker-compose up command :)

Nice work on this repo, btw!

omar-haris commented 7 years ago

@espizo why you not use " git clone [repo-url] " at docker file i think it well be better i'm right ?

espizo commented 7 years ago

@fiftysoft that would be a very atypical use of docker and it would involve a lot of issues setting up ssh keys for github inside docker, etc.

The normal workflow for docker-enabled git repos is:


$ git clone <repo url>
$ docker-compose up    # or docker build ... && docker run ...
omar-haris commented 7 years ago

@espizo thanks for your good work