search

omar-polo / gmid

a Gemini server
https://gmid.omarpolo.com
ISC License
98 stars 8 forks source link

Always send custom list of FastCGI parameters #17

Closed nytpu closed 1 year ago

nytpu commented 1 year ago

The code in fcgi_req to send the custom parameters set in the config file was placed inside the conditional for tls_peer_cert_provided, so the custom parameters would not be sent if a client certificate is not provided; this patch moves it out of the block so the params are always sent.

omar-polo commented 1 year ago

FastCGI parameters should always be sent, regardless of the client certificate. Applied, thank you!

Are you using fastcgi with gmid 1.8.4? if so i could tag a minor release of the 1.8 series with the fix. (the master branch is currently what will be 2.0 and there are various things to adjust before tagging that.)

The CI failure on FreeBSD is my fault, i forgot to provide a fallback for some constant that the master branch now uses.

nytpu commented 1 year ago

Ah, yeah I'm using 1.8.4, so if you don't mind a minor release would be great!

omar-polo commented 1 year ago

I've backported this (and a few other tweaks) and tagged 1.8.5 :)