search

omar / ByteSize

ByteSize is a utility class that makes byte size representation in code easier by removing ambiguity of the value being represented. ByteSize is to bytes what System.TimeSpan is to time.
MIT License
558 stars 50 forks source link

Migrate to csproj #35

Closed Tyrrrz closed 5 years ago

Tyrrrz commented 5 years ago

I'm using this library in an app that runs inside a docker container. Due to having been built with project.json format, this library requires an sdk image to run, which is significantly bigger than the runtime image. Switching to csproj should fix it.

omar commented 5 years ago

Hey @Tyrrrz, this will be solved in the 2.0 release (see v2.0.0-alpha). That version is built for .NET Standard and uses .csproj.

It seems to be pretty stable at the moment and I'm hoping to promote it to stable v2 after I finish reviewing comments on #24.

Tyrrrz commented 5 years ago

I'm not really interested in the metric changes in 2.0 and I would like this fix as soon as possible. I can make a PR with just this change, would you merge it?

Tyrrrz commented 5 years ago

Also I would need to use this library in a project targeting net45 (outside of docker)