Open tkdrob opened 5 years ago
Looks like there is an updated version here: https://github.com/kslr/deluge-autoremoveplus/
Unfortunately, it does not appear to compile without errors on python 3.7
It looks like kslr started working on updating it and gave up shortly after..... I have found a guide here: https://deluge.readthedocs.io/en/latest/devguide/how-to/update-1.3-plugin.html I might possibly work on updating this, but I know nothing about GTK, and I'm only so-so on python 3, so I'm not confident I'll make any progress.
I just submitted a pull request. Here is the egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
Appears to be working.
I do have many torrents to do a full test on it right now, but it appears to be good to go!
Will update this or the pull request if I encounter any issues.
I just submitted a pull request. Here is the egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
It didn't work for me :-(
I just submitted a pull request. Here is the egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
It didn't work for me :-(
Me neither, although it seems like the webui plugin upload thing isn't quite working properly in deluge for me...
I can confirm it is still working for me, including exemptions.
I manually put the plugin .egg into the plugins directory and restarted deluge. I did not use the WebUI plugin upload functionality.
EDIT: I did download the link from here I believe the link above in this thread used to be a broken version, but he edited it for the fixed version.
Tried installing manually and deluge throws the following error as soon as I click to enable it.
13:12:04 [ERROR ][deluge.pluginmanagerbase :154 ] Unable to instantiate plugin 'AutoRemovePlus' from '/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg'! 13:12:04 [ERROR ][deluge.pluginmanagerbase :1418] No module named 'core' Traceback (most recent call last): File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/__init__.py", line 46, in __init__ from core import Core as _plugin_cls ModuleNotFoundError: No module named 'core'
Tried installing manually and deluge throws the following error as soon as I click to enable it.
13:12:04 [ERROR ][deluge.pluginmanagerbase :154 ] Unable to instantiate plugin 'AutoRemovePlus' from '/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg'! 13:12:04 [ERROR ][deluge.pluginmanagerbase :1418] No module named 'core' Traceback (most recent call last): File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/__init__.py", line 46, in __init__ from core import Core as _plugin_cls ModuleNotFoundError: No module named 'core'
The error appears to come from an issue outside the scope of this plugin. If the plugin is unable to find the core module, then there are bigger issues at play. Please try a clean install/config/image depending on your setup, and make sure that you're using the most recent egg -- my edit in my previous comment changed the link to a build of an updated commit. Here is the most up-to-date egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
I am using the linuxserver/deluge docker image, which is a very popular distribution of deluge (has over 10 million pulls), and it's on docker so it's pretty much consistent across all it's users, and therefore easy to recreate.
Dropping the egg into the plugins folder doesn't work, although I have no errors in the logs either.
I am using the linuxserver/deluge docker image, which is a very popular distribution of deluge (has over 10 million pulls), and it's on docker so it's pretty much consistent across all it's users, and therefore easy to recreate.
Dropping the egg into the plugins folder doesn't work, although I have no errors in the logs either.
I am familiar with both the linuxserver/deluge and binhex/arch-delugevpn images as well as the checksum-verified consistency of Docker images. Nevertheless, everyone has different configs that may have all sorts of effects.
Please try manually editing your core.conf and core.conf~ configs and adding a line for AutoRemovePlus to the enabled_plugins setting. I have experienced many times that Deluge may add the plugin to the plugins/ directory and fail to enable it in the config. I have also seen that the enabled_plugins key-value pair is not persistent between restarts.
For reference, my enabled_plugins key-value in both core.conf and core.conf~ looks like this:
"enabled_plugins": [ "Execute", "AutoRemovePlus", "Label", "Extractor" ],
I had "enabled_plugins": ["Label", "AutoRemovePlus"], but no sign of the plugin working or appearing in the preferences page.
I had "enabled_plugins": ["Label", "AutoRemovePlus"], but no sign of the plugin working or appearing in the preferences page.
Is there a difference between the enabled_plugins values in core.conf~ and core.conf? Or did they both contain Label and AutoRemovePlus without needing to make any changes? Nothing coming up in the logs?
Nothing in the logs. I added it to the core.conf~ file manually it wasn't there. Although my understanding was that file was just a backup anyway? The core.conf~ file's last modified date was a long time ago for me.
Tried installing manually and deluge throws the following error as soon as I click to enable it.
13:12:04 [ERROR ][deluge.pluginmanagerbase :154 ] Unable to instantiate plugin 'AutoRemovePlus' from '/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg'! 13:12:04 [ERROR ][deluge.pluginmanagerbase :1418] No module named 'core' Traceback (most recent call last): File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/__init__.py", line 46, in __init__ from core import Core as _plugin_cls ModuleNotFoundError: No module named 'core'
The error appears to come from an issue outside the scope of this plugin. If the plugin is unable to find the core module, then there are bigger issues at play. Please try a clean install/config/image depending on your setup, and make sure that you're using the most recent egg -- my edit in my previous comment changed the link to a build of an updated commit. Here is the most up-to-date egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
I'm rebuilding my media server so this is a new computer, fresh OS/Deluge install, First 3rd-party plugin to be installed.
DISTRIB_DESCRIPTION="Ubuntu 19.04"
deluge-common/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-console/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluge-gtk/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-torrent/disco,now 1.3.15-2 all [installed] deluge-web/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-webui/disco,now 1.3.15-2 all [installed] deluge/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluged/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed]
I'll give the latest egg a try...
Nothing in the logs. I added it to the core.conf~ file manually it wasn't there. Although my understanding was that file was just a backup anyway? The core.conf~ file's last modified date was a long time ago for me.
Yes, core.conf~ is a backup. In my experience, sometimes there's an inexplicable difference between what Deluge loads and what core.conf says it should load. My guess was that it failed to use core.conf and fell back to using core.conf~, but this is most likely not the case. It is my own habit to add the plugins to both files.
Tried installing manually and deluge throws the following error as soon as I click to enable it.
13:12:04 [ERROR ][deluge.pluginmanagerbase :154 ] Unable to instantiate plugin 'AutoRemovePlus' from '/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg'! 13:12:04 [ERROR ][deluge.pluginmanagerbase :1418] No module named 'core' Traceback (most recent call last): File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/__init__.py", line 46, in __init__ from core import Core as _plugin_cls ModuleNotFoundError: No module named 'core'
The error appears to come from an issue outside the scope of this plugin. If the plugin is unable to find the core module, then there are bigger issues at play. Please try a clean install/config/image depending on your setup, and make sure that you're using the most recent egg -- my edit in my previous comment changed the link to a build of an updated commit. Here is the most up-to-date egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
I'm rebuilding my media server so this is a new computer, fresh OS/Deluge install, First 3rd-party plugin to be installed.
DISTRIB_DESCRIPTION="Ubuntu 19.04"
deluge-common/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-console/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluge-gtk/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-torrent/disco,now 1.3.15-2 all [installed] deluge-web/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-webui/disco,now 1.3.15-2 all [installed] deluge/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluged/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed]
I'll give the latest egg a try...
What version of Deluge are you using? Did you install it from apt-get install
or the deluge-torrent.org website? If you did install via apt-get install
, did you get it from the default Ubuntu repositories or did you add the Deluge Ubuntu PPA? It;s possible that the official Ubuntu repositories haven't updated Deluge to 2.0 yet, and it sounds to me like you may be using Deluge 1, because GTK and Python 3 changed the way the core module is used.
Nevermind, those versions listed are 2.0.3, up to date. Not sure what else could be causing this. Although it still may be worth checking if you're installing from the official Ubuntu repository or the Deluge PPA.
Tried installing manually and deluge throws the following error as soon as I click to enable it.
13:12:04 [ERROR ][deluge.pluginmanagerbase :154 ] Unable to instantiate plugin 'AutoRemovePlus' from '/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg'! 13:12:04 [ERROR ][deluge.pluginmanagerbase :1418] No module named 'core' Traceback (most recent call last): File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin instance = cls(plugin_name.replace('-', '_')) File "/home/deluge/.config/deluge/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/__init__.py", line 46, in __init__ from core import Core as _plugin_cls ModuleNotFoundError: No module named 'core'
The error appears to come from an issue outside the scope of this plugin. If the plugin is unable to find the core module, then there are bigger issues at play. Please try a clean install/config/image depending on your setup, and make sure that you're using the most recent egg -- my edit in my previous comment changed the link to a build of an updated commit. Here is the most up-to-date egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
I'm rebuilding my media server so this is a new computer, fresh OS/Deluge install, First 3rd-party plugin to be installed.
DISTRIB_DESCRIPTION="Ubuntu 19.04"
deluge-common/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-console/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluge-gtk/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-torrent/disco,now 1.3.15-2 all [installed] deluge-web/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed,automatic] deluge-webui/disco,now 1.3.15-2 all [installed] deluge/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed] deluged/disco,now 2.0.3-2~201906121747~ubuntu19.04.1 all [installed]
I'll give the latest egg a try...
Try
Python3 -V
If it's 3.6.8, rename the file to
AutoRemovePlus-0.6.2-py3.6.egg
Hey everyone, reporting in using Deluge 2.0.3 in a docker container based off of the archlinux/delugevpn image. Just used the latest AutoRemovePlus-0.6.2-py3.7 manually placed it in my plugins directory and rebooted deluge.
The plugin showed up in the list and is working as expected. Great work.
If you're using the linuxserver/deluge
docker image you will need to rename AutoRemovePlus-0.6.2-py3.7.egg
to AutoRemovePlus-0.6.2-py3.6.egg
when placing it in the plugins directory. After doing this and restarting the docker container the plugin showed up.
I just submitted a pull request. Here is the egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip
I pulled your egg and have it installed on the GTK version of Deluge, however I'm not sure how to config. I don't get a config option in the menu and the .conf is unfortunately not very clear. I don't mind just using the .conf directly if you can clarify the options.
I can't get this egg to install at all. I did it through the web interface first, and the plugin didn't show up. Then I did it through the gui and still doesn't show up in the plugin list. I copied the egg to the plugins folder and restarted deluge, and that didn't work either.
I'm running it on Ubuntu 19. Any ideas as to what I'm doing wrong?
Check your python version. If you're on 3.6 you'll have to rename the egg.
I had just fixed it and was typing it up when you posted that. The Python version fixed it. That said, are the settings supposed to show up in the GUI or is it supposed to be all manually editing the config files?
Should show up in the web UI, yeah. You might have to enable it first under the plug-in menu.
Should show up in the web UI, yeah. You might have to enable it first under the plug-in menu.
I did that. And the plugin is definitely working(I used the old 1.x config file for it). But it just doesn’t show up in options.
I have the plugin at least theoretically working, but in the standalone GTK client the options menu doesn't appear (the "built-in" plugins do appear when selected). Is there any info on how to just hand craft the .conf, or a solution to make the menu appear?
Does anyone else have a problem where the items don't actually get removed until you log into Deluge? For example, when I try to delete a downloaded file from the file system, I can't delete it because it's in use. So I log into Deluge, and I see it for a few seconds and then it disappears, and then I can delete it from the system.
Having a problem where this plugin doesn't remove anything. Same settings as with deluge 1.3.16. I see :39:29 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting in the log once I restart the docker, and never again.
I have the plugin at least theoretically working, but in the standalone GTK client the options menu doesn't appear (the "built-in" plugins do appear when selected). Is there any info on how to just hand craft the .conf, or a solution to make the menu appear?
Same here. The .conf from the previous version seems to work fine for me though. I'd suggest installing deluge 1.0, grabbing the old version of the .egg, creating the config you want, then converting to deluge 2.0 until the settings page is updated. Incredibly poor work around, but it's better than trying to figure out the .conf syntax.
Having a problem where this plugin doesn't remove anything. Same settings as with deluge 1.3.16. I see :39:29 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting in the log once I restart the docker, and never again.
I have the exact same problem! It works once and then when the docker container restarts it never does what it's supposed to until you manually change the settings and apply again. Can the devs comment here please?
I could update the plugin for python 3.7 and deluge 2, but there are just two problems: 1) can't yet install deluge 2 for arm debian (raspberry) 2) cannot create an account to write on the forum (the secret question doesn't accept the right answer).
@springjools The Deluge Team doesn't work?
No. The question is:
What answer to the above question is named after a person?: This question is a means of preventing automated form submissions by spambots.
"Debian 8, the old old stable, was named Jessie after the cowgirl in Toy Story 2, Toy Story 3 and Toy Story 4."
@springjools I see. Try Linux
Thanks. It worked. Overcomplicating things as usual.
Having a problem where this plugin doesn't remove anything. Same settings as with deluge 1.3.16. I see :39:29 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting in the log once I restart the docker, and never again.
I have the exact same problem! It works once and then when the docker container restarts it never does what it's supposed to until you manually change the settings and apply again. Can the devs comment here please?
Can you guys please fix this?!
Hello,
Is the plugin author still active? Otherwise maybe it's best to make a new plugin, specially since there are some mods of this plugin out there (ABIROID MOD eg). The question is what this plugin should really do.
And should it support python 3?
/Jools
On 27.10 2019 8:52, Kevin wrote:
Having a problem where this plugin doesn't remove anything. Same settings as with deluge 1.3.16. I see :39:29 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting in the log once I restart the docker, and never again.
I have the exact same problem! It works once and then when the docker container restarts it never does what it's supposed to until you manually change the settings and apply again. Can the devs comment here please?
Can you guys please fix this?!
Beats me. I'm new to Deluge and I know that I need this plugin, so.
I'm working on this plugin but I made some modifications, I'm not sure everybody wants these things.
I implemented the abiroid mod (https://www.invitehawk.com/topic/62648-deluge-using-autoremoveplus-to-auto-delete-old-torrents/?tab=comments#comment-216331), which can also remove unfinished torrents. But then it disabled the removal of seeding torrents, so I added that back as a separate option.
Then I also want to communicate bacl´k to sonarr/radarr that the downlaod has failed, I don't know if many people use those, but I want to be able to blacklist a release from deluge, so that it doesn't downlaod the same version again.
But I'm working with deluge 1.3.15, not sure if i can upgrade to deliuge 2.0
/Jools
On 27.10 2019 14:39, Kevin wrote:
Beats me. I'm new to Deluge and I know that I need this plugin, so.
Any progress on this @springjools? I wouldn't worry about what people want at this stage. Any progress is better than this repo being stale for the last 3 years.
As for the sonnarr/radarr stuff, I would love that, and I feel a lot of people use those services so would love that addon too!
Hopefully, you will find a way to develop it for deluge 2.0 also. I'm happy to provide debug support!
I managed to make the sonarr/radarr/lidarr interaction work when the calling in python in a standalone shell, but when I make the call in the plugin I get a HTTP 500 error. I think something in the call is making deluged crash. But that was with deluge 1.3.15. Now I just managed to update to deluge 2.0.3 and I have to first make the plugin work with this deluge version before I can test further.
I got it working now on python 3. Just hold on for a while while I move out hardcoded stuff into options. I also haven't tested it yet for any bugs but it's running right now at least.
@springjools Fantastic! Thanks for your work!
There's an updated version here now: https://github.com/springjools/deluge-autoremoveplus
There's an updated version here now: https://github.com/springjools/deluge-autoremoveplus
Hi! Thank you for your good work! I just can't get it to work I'm afraid... I am using linuxserver/deluge docker container. I initially tried with the egg file in your releases tab and it did show on Web UI, under plugins, but I couldn't enable it, if I check it and press ok, when I look at plugins again, it's unchecked.
After that, I cloned your git repo and built the egg file myself. The same thing happened unfortunately, it shows up perfectly under Plugins, but enabling it does nothing. I have tried also adding it manually to core.conf (and core.conf.bak). My enabled_plugins line looks like:
"enabled_plugins": [ "AutoAdd", "AutoRemovePlus", "Label" ]
and yet the plugin still doesn't show. The logs don't show anything, it's as if the entry isn't there. Any ideas? There is no AutoRemovePlus.conf file as the README suggests, so I really don't understand why this is happening. Thank you for your help.
Hello, probably some bug then, as i worked in an environment that had always had that plugin and never tried it on a clean environment. Which logs did you check? I have found that deluge puts a lot of things also in /var/log/daemon.log and also maybe in /var/log/syslog. Check those as well.
Also look in the web browser’s console. Firefox has it in tools->development->console or something similar.
Sent from my iPhone
On 17 Nov 2019, at 17:01, John Sklikas notifications@github.com wrote:
There's an updated version here now: https://github.com/springjools/deluge-autoremoveplus
Hi! Thank you for your good work! I just can't get it to work I'm afraid... I am using linuxserver/deluge docker container, which now uses Python 3.7.3. I initially tried with the egg file in your releases tab and it did show on Web UI, under plugins, but I couldn't enable it, if I check it and press ok, when I look at plugins again, it's unchecked.
After that, I cloned your git repo and built the egg file myself. The same thing happened unfortunately, it shows up perfectly under Plugins, but enabling it does nothing. I have tried also adding it manually to core.conf (and core.conf.bak). My enabled_plugins line looks like:
"enabled_plugins": [ "AutoAdd", "AutoRemovePlus", "Label" ]
and yet the plugin still doesn't show. The logs don't show anything, it's as if the entry isn't there. Any ideas? There is no AutoRemovePlus.conf file as the README suggests, so I really don't understand why this is happening. Thank you for your help.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@springjools
I am failing at "from .mediaserver import Mediaserver"
: [ERROR ][deluge.pluginmanagerbase :1343] No module named 'autoremoveplus.mediaserver'
: Traceback (most recent call last):
: File "/usr/lib/python3/dist-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin
: instance = cls(pluginname.replace('-', ''))
: File "/home/net/.config/deluge/plugins/AutoRemovePlus-0.6.6-py3.6.egg/autoremoveplus/init.py", line 48, in init
: from autoremoveplus.core import Core as _plugin_cls
: File "/home/usenet/.config/deluge/plugins/AutoRemovePlus-0.6.6-py3.6.egg/autoremoveplus/core.py", line 51, in
Where do I get mediaserver.py?
@springjools I have a slightly different error. Same sysmptoms as @isklikas, but I have an error log:
08:27:34.178 [ERROR ][deluge.pluginmanagerbase :79 ] Unable to instantiate plugin 'AutoRemovePlus' from '/config/plugins/AutoRemovePlus-0.6.6.egg'!
08:27:34.179 [ERROR ][deluge.pluginmanagerbase :79 ] No module named 'past'
Traceback (most recent call last):
File "/usr/lib/python3.8/site-packages/deluge/pluginmanagerbase.py", line 148, in enable_plugin
instance = cls(plugin_name.replace('-', '_'))
File "/config/plugins/AutoRemovePlus-0.6.6.egg/autoremoveplus/__init__.py", line 48, in __init__
from autoremoveplus.core import Core as _plugin_cls
File "<frozen zipimport>", line 259, in load_module
File "/config/plugins/AutoRemovePlus-0.6.6.egg/autoremoveplus/core.py", line 45, in <module>
from past.utils import old_div
ModuleNotFoundError: No module named 'past'
@cheesemarathon install python3-future
Oh fuck, I forgot to add a bunch of stuff to the release, no wonder it's not working. I just copied the folder to the cloned repo and pushed the diff, but github didn't automatically add new files. Here they are now.
But the .egg should still contain everything? Anyway, try now with these files.
And yes, some modules were added to maintain compatibility with both python 3 and 2, I think the past module is only needed for that old python 2 style division, which is probably not wanted anyway. In the ideal world, one should rewrite this whole plugin from scratch.
But it works now at least. I think the errors that happen when removing torrents are due to something trying to remove them twice. They do actually get removed still, but there is some error.
@springjools Thanks for this, but I've been trying the egg file for a couple days, but the plugin never enables. I check the box, click Apply, but when I come back to the preferences, it's unchecked again.
EDIT: I forgot to mention that I'm using the webui.
With Deluge 2 out, can we get this plugin updated to python 3 so we can use it?