search

omarfoq / FedEM

Official code for "Federated Multi-Task Learning under a Mixture of Distributions" (NeurIPS'21)
Apache License 2.0
155 stars 28 forks source link

Question about MOCHA #5

Closed Sherrylife closed 2 years ago

Sherrylife commented 2 years ago

Hi, @omarfoq, in the openreview(https://openreview.net/forum?id=YCqx6zhEzRp), you say that you implement the MOCHA algorithm in python and experimented with it. Can you updata this part of the code to your repository? I hace been implementing the MOCHA algorithm recently, but I am confused about the SDCA update part in the official matlab source code. I would like to see your implementation. Thank you very much!

omarfoq commented 2 years ago

Hello @Sherrylife,

I share this notebeook with my implementation of MOCHA. I tried to follow the official code, originally written in Matlab, in my implementation. Note however that this is an unofficial implementation.

I previously tried to incorporate Mocha in this repository, but I find its integration hard, as the logic of implementation differs a lot form the general structure of the code provided in FedEM. Instead, I will add the link of the notebook in the README.md file.

I hope this implementation is of some assistance to you. In case you spot any error, or have additional questions, please don't hesitate to ping me.

Sherrylife commented 2 years ago

Hello @Sherrylife,

I share this notebeook with my implementation of MOCHA. I tried to follow the official code, originally written in Matlab, in my implementation. Note however that this is an unofficial implementation.

I previously tried to incorporate Mocha in this repository, but I find its integration hard, as the logic of implementation differs a lot form the general structure of the code provided in FedEM. Instead, I will add the link of the notebook in the README.md file.

I hope this implementation is of some assistance to you. In case you spot any error, or have additional questions, please don't hesitate to ping me.

Wow! Thank you very much. I will review your code and get back to you as soon as possible.

Sherrylife commented 2 years ago

Hi, @omarfoq , I have read your notebook and run it successfully, and there is a tiny error in your notebook, which is highlighted in red in the figure("t" should be changed to "tt"). But it doesn't seem to affect the final result. image However, frustratingly, I still can't understand a few key updates in SDCA. I have sent an e-mail to the original author to ask her for some details. Unfortunately, maybe the original author was too busy to ignore my letter, but I really want to know some details about MOCHA. So I take the liberty of sending that email to you as well, I assure you that I came to you for help on my own reflection. Can you help me?

omarfoq commented 2 years ago

Hi,

Yes sure. Please send me a message on my email address (othmane.marfoq@inria.fr). In case I can help answering your question, I will do.

Also, since this topic is far from the objective of of this repository, I suggest we close this issue. Please, don't hesitate to open an issue, if something is still unclear for you.