search

omarryhan / sanic-cookies

The ultimate session management library for Sanic
MIT License
7 stars 3 forks source link

Not working with sanic==20.12.1 #4

Open 4doge opened 3 years ago

4doge commented 3 years ago

Hello there,

Not working, getting AttributeError: 'Request' object has no attribute 'session', since Sanic change the way how you should access/modify the Request instance.

Read more - https://github.com/xen/sanic_session/issues/62

Regars

omarryhan commented 3 years ago

Hello Anton,

This change has been in my mental-backlog for a while now. I was waiting for Sanic to deprecate their previous LTS version, so that we wouldn't have to support two different APIs. Now that their previous LTS is got deprecated, I'll try to fix this as soon as I get the time. Meanwhile, I'll be more than happy to accept a PR.

Thanks for raising the issue.

psylopunk commented 2 years ago

Hello Anton,

This change has been in my mental-backlog for a while now. I was waiting for Sanic to deprecate their previous LTS version, so that we wouldn't have to support two different APIs. Now that their previous LTS is got deprecated, I'll try to fix this as soon as I get the time. Meanwhile, I'll be more than happy to accept a PR.

Thanks for raising the issue.

But, with which version of sanic is library working stably now? :)

omarryhan commented 2 years ago

Good question! I honestly can't remember, should've written it down in the README when the breaking change happened. Last version I see working in my old apps was v19.6.0