search

omarss / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Consider returning a bool in CFX_FolderFontInfo::ScanFile() #157

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
void CFX_FolderFontInfo::ScanFile() can fail. Perhaps it needs to return false 
on error and check for that. See 
https://codereview.chromium.org/1098583002/diff/20001/core/src/fxge/ge/fx_ge_fon
tmap.cpp#newcode1360

There's also a couple of fseek() calls where the code does not check the return 
result.

Original issue reported on code.google.com by thestig@chromium.org on 8 May 2015 at 9:51