omarss / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

v8_base_3 does not compile for WindowsXP (platform toolset = v120_xp) #175

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.` change platform to Visual Studio 2013 - Windows XP (v120_xp)
2. Compile

What is the expected output? What do you see instead?
insted build ok I see
1>..\..\src\runtime\runtime-atomics.cc(159): error C3861: 
'_InterlockedExchange64': identifier not found
1>..\..\src\runtime\runtime-atomics.cc(159): error C3861: 
'_InterlockedExchangeAdd64': identifier not found
1>..\..\src\runtime\runtime-atomics.cc(159): error C3861: '_InterlockedAnd64': 
identifier not found
1>..\..\src\runtime\runtime-atomics.cc(159): error C3861: '_InterlockedOr64': 
identifier not found
1>..\..\src\runtime\runtime-atomics.cc(159): error C3861: '_InterlockedXor64': 
identifier not found

Original issue reported on code.google.com by PRumyant...@gmail.com on 29 Jun 2015 at 10:24

GoogleCodeExporter commented 9 years ago
this is true for compiling for 32-bit systems.
For 64-bit compilation is ok.

Original comment by PRumyant...@gmail.com on 29 Jun 2015 at 10:27

GoogleCodeExporter commented 9 years ago
Hey Bruce, do we make any claims to support this toolset?  Thanks.

Original comment by tsepez@chromium.org on 30 Jun 2015 at 10:28

GoogleCodeExporter commented 9 years ago
The only reason to support v120_xp is to make the binaries created run on XP - 
normally binaries created by the v120 toolset won't. Since our pdfium binaries 
presumably do run on XP that means we must be making that work through other 
methods.

Therefore there is no reason for anyone to change the toolset to v120_xp, and 
no need for us to support it.

If pdfium doesn't work on Windows XP for some reason then we could investigate 
why not and using v120_xp is one possible solution, but I don't think it is the 
solution that Chrome uses.

Original comment by brucedaw...@chromium.org on 30 Jun 2015 at 11:10