omarss / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Tons of files on the xfa branch have dos line endings #192

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
$ cat dos2unix 
#!/bin/sh

perl -pi -e 's/\r\n/\n/;' $*
$ find . -name '*.cpp' -o -name '*.h' | grep -E -v 
'third_party|thirdparties|lpng_v163|tiff_v403' | xargs ./dos2unix 

On the master branch, things look pretty good. On the xfa branch, tons of files 
have dos line endings.

Original issue reported on code.google.com by thakis@chromium.org on 6 Aug 2015 at 10:20

GoogleCodeExporter commented 8 years ago
By posting the shell script above, I'm guessing that you're not willing to take 
a stab at this Nico?  I'd be grateful ! Otherwise just assign this to me.

Original comment by tsepez@chromium.org on 6 Aug 2015 at 10:23

GoogleCodeExporter commented 8 years ago
Probably better if someone working with the people working on the xfa branch 
does this, so that there's a chance of it not regressing very quickly.

(Doing the conversion and checking in the files with the new line endings 
should take 4 minutes, so that part is easy.)

Original comment by thakis@chromium.org on 7 Aug 2015 at 6:28

GoogleCodeExporter commented 8 years ago
|{x: x is working on the xfa branch}| == 0.  We're pretty much just merging 
until I can get the tests straightened out on main.

Original comment by tsepez@chromium.org on 7 Aug 2015 at 6:37

GoogleCodeExporter commented 8 years ago
Don't we have a DOS line ending presubmit check in Chromium? Should we run sed 
and put in the presubmit check to enforce the line ending?

Original comment by thestig@chromium.org on 21 Aug 2015 at 6:34

GoogleCodeExporter commented 8 years ago
I couldn't find one when I looked for one for 2 minutes. I'm all for fixing 
this and having a presubmit, though.

Original comment by thakis@chromium.org on 25 Aug 2015 at 8:48