search

omarzina / substruct

Automatically exported from code.google.com/p/substruct
0 stars 0 forks source link

Patch: postgresql compatibility #138

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Attached patch (against trunk) fixes all postgresql issues found by the
tests in 1.0a6, while all tests in 1.0a6 still pass in a mysql db.

However, some tests in trunk don't pass (but are not related to the database).

Changed are:
* index names in db/schema.rb
* some mysql-specific SQL constructs (but I tried to keep the mysql
optimizations I didn't understood)
* a number of datatype related queries (using the boolean type in PG)

This also fixes issue #135 (db:bootstrap not working for Postgres).

Original issue reported on code.google.com by kar...@gmail.com on 9 Oct 2008 at 6:16

Attachments:

GoogleCodeExporter commented 8 years ago 
Sorry, it's issue #132, not #135.

Original comment by kar...@gmail.com on 9 Oct 2008 at 6:17

GoogleCodeExporter commented 8 years ago 
I assume it still works with mysql?

Original comment by rogerpack2005 on 10 Oct 2008 at 9:45

GoogleCodeExporter commented 8 years ago 
Applied against 1.0a6, all (including a few added) but one tests are OK with 
both
mysql and PG.
Applied against trunk, five or six tests fail for both databases (but the same 
tests
fail with an unpatched trunk).
I have not tried much of the application against the MySQL DB.

Original comment by kar...@gmail.com on 11 Oct 2008 at 12:16

GoogleCodeExporter commented 8 years ago 
Please apply against newest trunk. All tests are passing here. Should pass with 
your patch as well. Resubmit after 
testing against current trunk circa r160.

I don't have time to debug your patches!

Original comment by subim...@gmail.com on 2 Nov 2008 at 10:26

GoogleCodeExporter commented 8 years ago 
Marking this as "wontfix" until I get a working, tested patch. Sorry.

Original comment by subim...@gmail.com on 25 Jan 2009 at 2:30