Region Outline Toggle - Githubissues

ombucore / drupal-ombuwire

Help OMBU wire up a Drupal site

0 stars 0 forks source link

Region Outline Toggle #7

Closed EvanLovely closed 13 years ago

EvanLovely commented 13 years ago

It would be sweet if the little floating menu on the left had a toggle for the region outlines and labels. Maybe have the default be off as well? Also, is GitHub Issues an appropriate place for requests like this?

axolx commented 13 years ago

Jon -- Maybe all markup & css should be added by the toggle w/JS as opposed to coming from the backend? Also let's have the checkbox state saved in a cookie to persist page reloads.

EvanLovely commented 13 years ago

I'd suggest a body class getting added via JS (.region-outlines-on for example) and then letting descending CSS handle the styling.

jonathanpglick commented 13 years ago

done in commit 8d2f480d89445c84973e4cdc6ffe749c25b8adf1

Outlines added via body class, labels generated w/ js from the "region-{name}" classes.