ombulabs / mercadopago

Gem to communicate with the MercadoPago API
33 stars 22 forks source link

Use TLS v1.2 by default #40

Closed mauro-oto closed 6 years ago

mauro-oto commented 6 years ago

Hey,

Starting June 30th 2018, MercadoPago drops TLS v1.0 support: http://beta.mercadopago.com.ar/developers/es/guides/pci-compliant-merchants/disabling-tls-10

This means only TLS v1.1 and TLS v1.2 will be supported by the API, and Ruby 1.9.3 will not be supported since TLS v1.1 and TLS v1.2 support was introduced in Ruby 2.0.0.

I'm forcing a TLS v1.2 connection because Faraday requires at least Ruby 2.5 to be able to set a min/max SSL version.

Please check it out and let me know what you think, thanks!

etagwerker commented 6 years ago

@mauro-oto Looks good! Considering that we're dropping support for a Ruby version, I think this should represent a major version change. Were you planning to release a bump to v3.0.0?

mauro-oto commented 6 years ago

I'll merge this and release a v3.0.0 version then :+1: