search

omcljs / om

ClojureScript interface to Facebook's React
6.66k stars 363 forks source link

send-cb should use reconcile! #820

Closed julienfantin closed 7 years ago

julienfantin commented 7 years ago

The send-cb fn in the reconciler's add-root! is implemented with merge!.

This forces the app to re-render from the root regardless of the result and/or the query being merged.

This could be prevented by implementing send-cb with reconcile! instead.

swannodette commented 7 years ago

Thanks for the report. I think can be easily solved with a queue but for remotes.

swannodette commented 7 years ago

@julienfantin I pushed a potential fix to master, please test. Thanks.

julienfantin commented 7 years ago

Just reporting that these changes have been working well for us 👍

For anyone looking, the commits are around: 74549c287930c4afa359b9c8f3fc18cd19834d73