Open calvis opened 7 years ago
@calvis is targeting nil
intentional here?
FWIW, what causes the issue is that a nil
target causes :root
in the reconciler to be a React element rather than a component instance, which fails the component?
check in get-query
@swannodette I thought nil
was an acceptable thing to target (e.g. I want to test the behavior of the reconciler after an add-root!
to see what my state is after all the remote calls). If I need to get a dom element for testing that's fine too I guess.
@calvis I sometimes use React's TestUtils, which provides a shallow renderer you can render your app to.
I'm seeing different results for
merge!
after anadd-root!
when the target is a dom element vs.nil
. This is not intuitive & is making testing hard, so I'm hoping it's a bug.