search

omcljs / om

ClojureScript interface to Facebook's React
6.66k stars 363 forks source link

wip to allow dynamic queries #857

Closed sc13-bioinf closed 7 years ago

sc13-bioinf commented 7 years ago

Need to integrate with get/set query

anmonteiro commented 7 years ago

This looks like a too big diff for what would otherwise be a simple change.

We just need to see if the state is an atom. If it is, keep doing what we do. If it's not, store dynamic queries somewhere else. The reason why no one worked on this issue before is because we haven't decided where to store runtime queries in the second case.

It is generally preferred to discuss these things on e.g. Slack before putting in work that may not be considered.