Right now, this block of code can result in a race condition that can stop future reconciling from occurring. Block of code inlined next for convenience:
([resp query remote]
(when-not (nil? remote)
(p/queue! this (keys resp) remote))
(merge! this resp query remote)
(p/reconcile! this remote))))))))
In particular, (merge! ...) will cause a state change that can trigger a (schedule-render! ...) and therefore eventually a reconcile. In cases where the requestAnimationFrame immediately runs the scheduled reconcile, "eventually" becomes "immediately." During this immediate reconcile, the following line will set :queued to false:
(swap! state update-in [:queued] not)
In this scenario, the last(p/reconcile! this remote) in the code block above will run right after the reconcile triggered by requestAnimationFrame. This reconcile will also call the following line:
(swap! state update-in [:queued] not)
which will set :queued back to true, without adding enqueueing anything to :queue-remote or :queue.
This puts our reconciler into a state in which subsequent calls to schedule-render! will think that there is already a render scheduled and won't queue a render and reconcile.
Fixes GH-862.
Right now, this block of code can result in a race condition that can stop future reconciling from occurring. Block of code inlined next for convenience:
In particular,
(merge! ...)
will cause a state change that can trigger a(schedule-render! ...)
and therefore eventually a reconcile. In cases where therequestAnimationFrame
immediately runs the scheduled reconcile, "eventually" becomes "immediately." During this immediate reconcile, the following line will set:queued
tofalse
:In this scenario, the last
(p/reconcile! this remote)
in the code block above will run right after the reconcile triggered byrequestAnimationFrame
. This reconcile will also call the following line:which will set
:queued
back totrue
, without adding enqueueing anything to:queue-remote
or:queue
.This puts our reconciler into a state in which subsequent calls to
schedule-render!
will think that there is already a render scheduled and won't queue a render and reconcile.where
p/schedule-render!
is defined as follows:This means that any reconciles that would result from a change in our reconciler
:state
won't trigger a reconcile. See here:And the symptom will be observed state changes not re-rendering our ui.