Closed joshmoore closed 2 years ago
As far as I can tell, this should get us what we need to deploy to artifactory which should unblock https://github.com/ome/openmicroscopy/pull/6292
Two things though:
<provided>
we might be able to go straight to maven central if we think it's worth the investigation.The provided
scope is interesting and I would definitely like to explore the option of deploying these to Maven Central. In terms of architecture, I think the primary downside is that it would not be propagated to downstream projects i.e. the dependency might need to be declared explicitly in https://github.com/ome/openmicroscopy/pull/6292
(and especially if we go straight to maven central) we should consider the artifact name. e.g. will ZarrWriter be added here as well?
A few considerations:
org.openmicroscopy
Zarr{Reader,Writer}
be prefixed with OME
to indicate this is a specialized version of the Zarr specification with the NGFF conventionformats-zarr
(to match formats-gpl
/formats-bsd
), ome-zarr
@dgault : if you have a moment post-release, pre-vacation to capture your thoughts here, I can try to make some head way.
For the sake of consistency with the other format jars I would be happy deploying to artifactory for now at least. I would also see this as the logical place to also add the ZarrWriter rather than having each separately.
On the naming side of things, Im open to adding the OME prefix to ZarrReader/ZarrWriter, that shouldn't be much of an issue at this stage. For the artefact name I would be tempted to go for formats-zarr
, again for consistency sake if it is being used as a Bio-Formats external reader and writer. But that really does depends on what the long term usage of this repo looks like.
Ok. So summarizing:
<provided>
to the pom.xml for maven centralKnowing that we need the readers.txt bump anyway, I wonder if we don't try to get this into artifactory as is so we can test in merge-ci and then I'll start another PR with changes 1-4 targeting maven central. We can always back out the releases to artifactory (which is less easy with maven central)
Out-of-band thumbs up. Moving forward with 0.1.0 (with the understanding that it may disappear into the æther)
ome.snapshots/ome/OMEZarrReader/0.1.0-SNAPSHOT/
now has two deployments (mvn deploy
) with these settings:settings.xml
``` (base) /opt/ZarrReader $cat ~/.m2/settings.xmlThe first still had the
*.jar-with-dependencies.jar
(new name) and the second no longer does thanks to the<attach>
element in the pom.cc: @sbesson @dgault