ome / ZarrReader

Other
5 stars 8 forks source link

naming of images in omero #36

Open pwalczysko opened 2 years ago

pwalczysko commented 2 years ago

See https://github.com/ome/ZarrReader/pull/31#issuecomment-1113459183 and https://github.com/ome/ZarrReader/pull/31#issuecomment-1113477796 for background.

First suggestion would be:

  1. Any system which propagates the original filename from the starting format is acceptable.
  2. System which alters the filenames in the process is acceptable only if additions or logical replacements are made (such as extension ome.zarr replaces ome.tiff, and the name will be longer because... (cannot imagine why), but the original string from the starting format should be there in full

cc @sbesson

For what it is worth, the system I am using in testing is actually encapsulating the name of the original file in the name of the top folder, such as blah.ome.tiff will become blah.ome.zarr/ folder as produced by bf2raw. It might be an option to simply harvest this folder name, but possibly too short-sighted, as it might not work on S3 ?

pwalczysko commented 2 years ago

@joshmoore @dgault

sbesson commented 2 years ago

A few thoughts

At least from my side, there are two possible sources of truth:

In terms of timeline, the current progression is to target an OMERO.server release including this reader to start supporting and gaining experience on OME-NGFF import. Does anyone feel this issue should be elevated as a blocker that we need to address? And/or would a new paragraph in the limitations section of the OMERO documentation be sufficient?

joshmoore commented 2 years ago
  • the name of the Zarr folder e.g. blah.ome.zarr which we can reasonably expect to be named similarly to the original data.

Perhaps this is dependent on what's in the top-level .zattrs? Three current cases are: plain image, HCS, or bioformats2raw series. Your statement certainly makes sense for the first of these.