search

ome / ZarrReader

Other
7 stars 11 forks source link

Class cast exception when parsing metadata #95

Open dgault opened 3 months ago

dgault commented 3 months ago

This PR is a follow up to https://github.com/ome/ZarrReader/issues/94 I have simply taken the 2 commits from the fork by @jo-mueller : https://github.com/jo-mueller/ZarrReader/tree/fix-classcast-exception

Fixes #94

jo-mueller commented 3 months ago

Cool! If that fixes the error, could you include me as a co-author of the commits from my fork? Or did you copy the commits altogether?

dgault commented 3 months ago

Looks like the tests are failing to build due to parseOmeroMetadata being a private method.

@jo-mueller, you can certainly be added to the list of contributors if this change gets included. We have a Contributor License Agreement for the project, would you be able to sign and return the form following the instructions on https://ome-contributing.readthedocs.io/en/latest/cla.html

jo-mueller commented 3 months ago

Hi @dgault , thanks for moving this forward. I already signed the OME agreeement for this PR: https://github.com/ome/omero-py/pull/394

joshmoore commented 3 months ago

@jo-mueller: :+1: on the signing. A heads up in case you haven't seen https://forum.image.sc/t/bio-formats-support/101109, though, you might want to re-open this under your own account.

jo-mueller commented 3 months ago

Hi @joshmoore,

thanks for the heads-up. I could open a PR with the two commits myself, the issue with that would be that I myself will be on parental leave until December starting the coming Friday. I could probably greenlight any changes to the PR from the mobile app but I think t would be better if somehow could see this through with more regular access to their devices :/

joshmoore commented 3 months ago

Understood, and enjoy! If this hasn't made it in by the time you're back, feel free to speak up loudly.

jo-mueller commented 3 months ago

Understood, and enjoy! If this hasn't made it in by the time you're back, feel free to speak up loudly.

I'll hold you to it at next year's TiM conference latest if I meet you there ;)