ome / ansible-role-omero-server

Installs and configures OMERO.server
https://galaxy.ansible.com/ome/omero_server/
BSD 2-Clause "Simplified" License
4 stars 14 forks source link

Remove omero_server_systemd_require_network #53

Closed manics closed 3 years ago

manics commented 4 years ago

Many OSes are moving away from the network.service scripts, so we shouldn't require it, especially since this still has "After=network.service" which means start after the network.service if it's enabled, otherwise ignore.

I'm undecided on whether this can go in alongside https://github.com/ome/ansible-role-omero-server/pull/50 which is an example of a distribution that uses an alternative to network.service since it shouldn't break existing deployments (since After=network.service is kept) or whether it counts as a breaking change.

snoopycrimecop commented 4 years ago

Conflicting PR. Removed from build ANSIBLE-ROLES-merge#1061. See the console output for more details. Possible conflicts:

--conflicts

snoopycrimecop commented 4 years ago

Conflicting PR. Removed from build ANSIBLE-ROLES-merge#1062. See the console output for more details. Possible conflicts:

--conflicts

manics commented 3 years ago

See https://github.com/ome/ansible-role-omero-server/pull/55 instead