ome / ansible-role-omero-web

Installs and configures OMERO.web and Nginx
BSD 2-Clause "Simplified" License
1 stars 14 forks source link

Run restorecon if selinux enabled #21

Closed manics closed 5 years ago

manics commented 5 years ago

Fixes #15 Replacement for https://github.com/ome/ansible-role-omero-web/pull/19

This should also work as expected in check-mode (give a status output without making changes). Untested.

manics commented 5 years ago

This was used to deploy https://github.com/ome/prod-playbooks/pull/186 without manual intervention

sbesson commented 5 years ago

Looks good from a code-review perspective and hopefully should reduce manual steps when upgrading a Web deployment with SELinux enabled.

I will have a go at testing the downgrade/upgrade process using pub-omero later this week. If this passes, this should be ready to merge and release.

sbesson commented 5 years ago

After a couple tries, I failed to reproduce the issue #15 on pub-omero while downgrading/upgrading OMERO.web in isolation. I'll propose this a try within a context of a full deployment and get it merged and tagged as a patch release of the role.

sbesson commented 5 years ago

Successfully tested in and outside check-mode with https://github.com/ome/prod-playbooks/pull/192