Fix Ansible version_compare change in behaviour

ome / ansible-role-omero-web

Installs and configures OMERO.web and Nginx

BSD 2-Clause "Simplified" License

1 stars 14 forks source link

Fix Ansible version_compare change in behaviour #22

Closed manics closed 4 years ago

manics commented 4 years ago

Non-standard strings (e.g. CI job names) can no longer be compared against versions. Since this usually indicates a CI build unconditionanally upgrade.

Also fixes a deprecation warning: [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using result|version_compare use result is version_compare. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

manics commented 4 years ago

This will need to wait for https://github.com/ome/ansible-role-omero-web/issues/23

sbesson commented 4 years ago

See https://github.com/ome/ansible-role-omero-server/pull/39#issuecomment-549893976 for the companion PR on the ome.omero_server role and the discussion on the upgrade semantics.