search

ome / ansible-role-omero-web

Installs and configures OMERO.web and Nginx
BSD 2-Clause "Simplified" License
1 stars 14 forks source link

If omero_web_apps_top_links .attrs not set omit #35

Closed manics closed 4 years ago

manics commented 4 years ago

attrs is optional in the top-links setting. It may or may not matter whether it's {} vs omitted.

joshmoore commented 4 years ago

Travis fails with:

 File \"/opt/omero/omego/lib/python2.7/site-packages/omego/artifacts.py\", line 63, in download", "    componenturl = self.artifacts.get(component)", "  File \"/opt/omero/omego/lib/python2.7/site-packages/omego/artifacts.py\", line 203, in get", "    raise ArtifactException('No match for component', component)", "omego.artifacts.ArtifactException: No match for component", "path: python"], "stdout": "", "stdout_lines": []}

i.e. the missing OMERO.py.zip. Do you want to fix here or in a separate PR?

(Otherwise, change looks fine)

manics commented 4 years ago

Done!

joshmoore commented 4 years ago

Merging based on green travis status. I assume this can and should go out as 3.0.1.

I'm unclear on the python2-ness of the test and if it's going to stay that way. I also assume that can safely be handled in a follow-up.