search

ome / ansible-role-omero-web

Installs and configures OMERO.web and Nginx
BSD 2-Clause "Simplified" License
1 stars 14 forks source link

Add ICE package locations for Ubuntu 20.04 and CentOS 8 #38

Closed stephenogg closed 3 years ago

stephenogg commented 3 years ago

Modified the defaults so that the omero_web_python_requirements_ice_package is populated with the correct address depending on the distribution and the version of the OS.

joshmoore commented 3 years ago

Thanks for this, @SteveO-sudo! Will you have a chance to push a fix for the lint failures?

With the change of the omero_web_python_requirements_ice_package dictionary, I'd propose this as 4.0.0. cc: @sbesson @manics

manics commented 3 years ago

Before this is tagged can someone make sure there are molecule test scenarios, either in this PR or a follow up?

sbesson commented 3 years ago

Coming back to this following #40, I have merged origin/master, fixed the yamllint warnings and added an Ubuntu 20.04 scenario at https://github.com/sbesson/ansible-role-omero-web/commit/af92c3b041f3579a1442629dd308c37448c6d226. The new scenario currently fails at https://github.com/sbesson/ansible-role-omero-web/runs/2192717019?check_suite_focus=true with

    TASK [ome.python3_virtualenv : python3 venv | install python3] *****************
    fatal: [omero-web-active-ubuntu2004]: FAILED! => {"changed": false, "msg": "No package matching 'python3.6' is available"}

which brings us back to the proposed fixes in https://github.com/ome/ansible-role-python3-virtualenv/pull/2. So I'll focus on reviewing, merging and tagging the changes in the upstream ome.python3_virtualenv role first and then come back to this.

sbesson commented 3 years ago

With the release of ome.python3_virtualenv, all the Molecule tests are passing under the various platforms including Ubuntu 20.04. I used a different base Docker image for Ubuntu + systemd which had tags for 20.04 as well as 18.04. I have not reviewed whether a more authoritative Docker image including systemd would exist although this will likely impact other roles/playbooks.

As discussed in https://github.com/ome/ansible-role-omero-web/pull/38#issuecomment-754619633, my vote would be to resolve these final matters, merge and release ome.omero_web 4.0.0 with Ubuntu 20.04 support.