Closed christianrickert closed 1 year ago
Hi @christianrickert, thank you for reporting the issue and providing aa sample file. This looks to be an odd issue as the IonpathMIBITiffReader hasn't changed in quite some time. I tested the sample file with Bio-Formats 6.12.0 and was unable to reproduce the exception. When looking into the metadata in the file, it is always using "image.type":"SIMS"
which is correct and shouldn't produce any issue.
The stack trace from the ImageJ plugin is perhaps a bit misleading as you will see the same stack for many different types of exceptions caught in the plugin.
Since the version that worked for you was a version that shipped directly with FIJI, I suspect the issue may be with the dependencies in your FIJI environment when modifying it from the update site. Could you list the names of jars in your FIJI/jars
folder and also FIJI/jars/bio-formats
?
hi @dgault, thanks for looking into this issue!
Here's the diff information after the update, which breaks the image import:
--- C:\Users\Christian Rickert\Desktop\working.txt
+++ C:\Users\Christian Rickert\Desktop\broken.txt
@@ -1,20 +1,20 @@
Directory of C:\Software\Fiji.app\jars\bio-formats
-12/01/2022 03:44 PM 142,617 formats-api-6.11.1.jar
-12/01/2022 03:44 PM 908,900 formats-bsd-6.11.1.jar
-12/01/2022 03:44 PM 1,515,803 formats-gpl-6.11.1.jar
+03/17/2023 09:33 AM 142,597 formats-api-6.12.0.jar
+03/17/2023 09:33 AM 909,142 formats-bsd-6.12.0.jar
+03/17/2023 09:33 AM 1,517,182 formats-gpl-6.12.0.jar
12/01/2022 03:44 PM 511 jai_imageio-0.0.0-STUB.jar
12/01/2022 03:44 PM 508,170 jxrlib-all-0.2.4.jar
-12/01/2022 03:44 PM 14,129 metakit-5.3.4.jar
-12/01/2022 03:44 PM 94,415 ome-codecs-0.4.1.jar
-12/01/2022 03:44 PM 142,397 ome-common-6.0.13.jar
+03/17/2023 09:33 AM 14,139 metakit-5.3.5.jar
+03/17/2023 09:33 AM 94,394 ome-codecs-0.4.4.jar
+03/17/2023 09:33 AM 142,438 ome-common-6.0.14.jar
12/01/2022 03:44 PM 1,050,320 ome-jai-0.1.3.jar
12/01/2022 03:44 PM 92,339 ome-mdbtools-5.3.2.jar
12/01/2022 03:44 PM 951,883 ome-poi-5.3.7.jar
-12/01/2022 03:44 PM 676,795 ome-xml-6.3.1.jar
-12/01/2022 03:44 PM 629,575 specification-6.3.1.jar
-12/01/2022 03:44 PM 1,296,289 turbojpeg-6.11.1.jar
- 14 File(s) 8,024,143 bytes
+03/17/2023 09:33 AM 652,500 ome-xml-6.3.2.jar
+03/17/2023 09:33 AM 629,511 specification-6.3.2.jar
+03/17/2023 09:33 AM 1,296,289 turbojpeg-6.12.0.jar
+ 14 File(s) 8,001,415 bytes
Directory of C:\Software\Fiji.app\jars
@@ -64,7 +64,7 @@
12/01/2022 03:44 PM 984,052 bigdataviewer-core-10.4.3.jar
12/01/2022 03:44 PM 76,089 bigdataviewer-vistools-1.0.0-beta-31.jar
12/01/2022 03:44 PM 368,632 bij-1.0.0.jar
-03/14/2023 11:07 AM <DIR> bio-formats
+03/17/2023 09:33 AM <DIR> bio-formats
12/01/2022 03:44 PM 60,250 blas-0.8.jar
12/01/2022 03:44 PM 208,593 bounce-0.18.jar
12/01/2022 03:44 PM 485,354 bsh-2.1.0.jar
@@ -243,7 +243,7 @@
12/01/2022 03:44 PM 9,534,389 jruby-core-9.1.17.0.jar
12/01/2022 03:44 PM 8,892,481 jruby-stdlib-9.1.17.0.jar
12/01/2022 03:44 PM 282,591 jsch-0.1.55.jar
-12/01/2022 03:44 PM 45,944 json-20090211.jar
+03/17/2023 09:33 AM 70,348 json-20220924.jar
12/01/2022 03:44 PM 293,671 jsoup-1.7.2.jar
12/01/2022 03:44 PM 59,716 jsr166y-1.7.0.jar
12/01/2022 03:44 PM 19,936 jsr305-3.0.2.jar
@@ -408,4 +408,4 @@
12/01/2022 03:45 PM 120,069 xpp3-1.1.4c.jar
12/01/2022 03:45 PM 116,013 xz-1.9.jar
12/01/2022 03:45 PM 511 yecht-0.0.0-STUB.jar
- 388 File(s) 244,722,475 bytes
+ 388 File(s) 244,746,879 bytes
In addition to the updates to Bio-Formats, I see that the json-*.jar
was updated as a dependency.
Thanks @christianrickert, it does indeed seem to be related to the json jar. I was able to reproduce the issue you are seeing with the json-20220924 jar. The issue seems to occur when reading the channel.mass
value from the JSON description, with previous versions of the jar this returned a String value but with the latest 20220924 version it is now returning a double value.
The reader will need to be updated to handle both of the possible return values. Until that is updated you would be best reverting back to the json-20090211.jar
if possible.
Very nice! 👏
I got a dependency warning when updating Bio-Formats to the latest version:
Looks like the dependency is only evaluated during installation, not at runtime. - I kept a copy of the older version and replaced the new version.
Do you think it's worth communicating this issue in the json-*.jar
to the corresponding folks? An altered return type will break a lot of workflows and would require a lot of readers to be fixed too.
Yeah we will certainly follow up with the ImageJ team on this. Firstly I have opened a PR to look at bumping the json dependency on our side and that will let me see exactly what the impact is and how many readers will be affected - https://github.com/ome/bioformats/pull/3966
Much appreciated! 🤝
Closing as this has been resolved with the dependency updates in 6.13.0
There might be a issue with Bio-Formats when importing of Ionpath MIBITIFF-compatible files in ImageJ 1.54c (Java 1.8.0_322, 64-bit):
Example: [FOV1-1] MoQC-100.zip
Bio-Formats 6.10.1 (plugins/bio-formats_plugins-6.10.1-20220731.012559-15.jar), from Bio-Formats in ImageJ Updater
Bio-Formats 6.11.1 (plugins/bio-formats_plugins-6.11.1.jar), currently ships with Fiji
Bio-Formats 6.12.0 (plugins/bio-formats_plugins-6.12.0.jar), updated by ImageJ Updater's default sites
The latest commit in IonpathMIBITiffReader.java was on September 17, 2018.
Independent from the specific file type, I can see the
step is FILE, but must be after STACK
error being described earlier image.sc: Cannot import .czi stacks to FIJI Some .ndpi files not opening in Qupath v0.4.1 Exception Issue when opening .nd2 files with Bio-Formats Error importing .czi videos